Repository navigation
feat(cli-test): add the trace IDs from Slack CLI v4.14.0 - #2863
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 49c8ca2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2863 +/- ##
==========================================
+ Coverage 94.37% 94.43% +0.06%
==========================================
Files 67 67
Lines 10809 10824 +15
Branches 679 676 -3
==========================================
+ Hits 10201 10222 +21
+ Misses 577 574 -3
+ Partials 31 28 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SEND_ERROR: 'SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SEND_ERROR', | ||
| SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SHOULD_SEND: 'SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SHOULD_SEND', | ||
| SLACK_TRACE_ADMIN_APPROVAL_REQUIRED: 'SLACK_TRACE_ADMIN_APPROVAL_REQUIRED', | ||
| SLACK_TRACE_APP_LINK_START: 'SLACK_TRACE_APP_LINK_START', |
There was a problem hiding this comment.
thought (non-blocking): These drifted 15 IDs behind before anyone noticed. A small test or CI step that diffs SlackTracerId against the CLI's slacktrace.go could catch the next release for us.
|
🌟 Thanks for the kind review @mwbrooks! |
Summary
This pull request adds the 15
SlackTracerIdvalues that Slack CLI v4.14.0 prints but@slack/cli-testdidn't list yet, so tests can wait on them. Each one matchesinternal/slacktrace/slacktrace.goin slackapi/slack-cli:app link:SLACK_TRACE_APP_LINK_START,SLACK_TRACE_APP_LINK_SUCCESSapp settings:SLACK_TRACE_APP_SETTINGS_START,SLACK_TRACE_APP_SETTINGS_SUCCESSapp unlink:SLACK_TRACE_APP_UNLINK_START,SLACK_TRACE_APP_UNLINK_SUCCESSblocks preview:SLACK_TRACE_BLOCKS_PREVIEW_START,SLACK_TRACE_BLOCKS_PREVIEW_SUCCESScreate:SLACK_TRACE_CREATE_CATEGORY_OPTIONSdocs:SLACK_TRACE_DOCS_GET_SUCCESS,SLACK_TRACE_DOCS_SEARCH_SUCCESS,SLACK_TRACE_DOCS_SUCCESSenv init:SLACK_TRACE_ENV_INIT_SUCCESSproject init:SLACK_TRACE_PROJECT_INIT_STARTED,SLACK_TRACE_PROJECT_INIT_SUCCESSNew entries go in sorted order without re-sorting the existing ones. Every value on
mainalready matches the CLI, so nothing else changes.Testing
npm testinpackages/cli-test: 108 tests pass.npx @biomejs/biome check packages/cli-testpasses.Requirements
🤖 Generated with Claude Code