Skip to content

feat(cli-test): add the trace IDs from Slack CLI v4.14.0 - #2863

Merged
mwbrooks merged 1 commit into
mainfrom
cli-test-latest-traces
Nov 17, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
cli-test-latest-traces

Conversation

@zimeg

@zimeg zimeg commented Nov 17, 2026

Copy link
Copy Markdown
Member

Summary

This pull request adds the 15 SlackTracerId values that Slack CLI v4.14.0 prints but @slack/cli-test didn't list yet, so tests can wait on them. Each one matches internal/slacktrace/slacktrace.go in slackapi/slack-cli:

  • app link: SLACK_TRACE_APP_LINK_START, SLACK_TRACE_APP_LINK_SUCCESS
  • app settings: SLACK_TRACE_APP_SETTINGS_START, SLACK_TRACE_APP_SETTINGS_SUCCESS
  • app unlink: SLACK_TRACE_APP_UNLINK_START, SLACK_TRACE_APP_UNLINK_SUCCESS
  • blocks preview: SLACK_TRACE_BLOCKS_PREVIEW_START, SLACK_TRACE_BLOCKS_PREVIEW_SUCCESS
  • create: SLACK_TRACE_CREATE_CATEGORY_OPTIONS
  • docs: SLACK_TRACE_DOCS_GET_SUCCESS, SLACK_TRACE_DOCS_SEARCH_SUCCESS, SLACK_TRACE_DOCS_SUCCESS
  • env init: SLACK_TRACE_ENV_INIT_SUCCESS
  • project init: SLACK_TRACE_PROJECT_INIT_STARTED, SLACK_TRACE_PROJECT_INIT_SUCCESS

New entries go in sorted order without re-sorting the existing ones. Every value on main already matches the CLI, so nothing else changes.

Testing

  • npm test in packages/cli-test: 108 tests pass.
  • npx @biomejs/biome check packages/cli-test passes.

Requirements

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 17, 2026 05:26
@zimeg zimeg added this to the cli-test@next milestone Nov 17, 2026
@zimeg zimeg added semver:minor enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` labels Nov 17, 2026
@zimeg zimeg self-assigned this Nov 17, 2026
@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 49c8ca2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@slack/cli-test Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.43%. Comparing base (6fc548b) to head (49c8ca2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
+ Coverage   94.37%   94.43%   +0.06%     
==========================================
  Files          67       67              
  Lines       10809    10824      +15     
  Branches      679      676       -3     
==========================================
+ Hits        10201    10222      +21     
+ Misses        577      574       -3     
+ Partials       31       28       -3     
Flag Coverage Δ
cli-hooks 94.28% <100.00%> (+<0.01%) ⬆️
cli-test 94.28% <100.00%> (+<0.01%) ⬆️
logger 94.28% <100.00%> (+<0.01%) ⬆️
oauth 94.28% <100.00%> (+<0.01%) ⬆️
socket-mode 94.28% <100.00%> (+<0.01%) ⬆️
web-api 94.28% <100.00%> (+<0.01%) ⬆️
webhook 94.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! Checking all 15 against slacktrace.go makes this an easy one, and every value lines up with v4.14.0.

SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SEND_ERROR: 'SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SEND_ERROR',
SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SHOULD_SEND: 'SLACK_TRACE_ADMIN_APPROVAL_REQUEST_SHOULD_SEND',
SLACK_TRACE_ADMIN_APPROVAL_REQUIRED: 'SLACK_TRACE_ADMIN_APPROVAL_REQUIRED',
SLACK_TRACE_APP_LINK_START: 'SLACK_TRACE_APP_LINK_START',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): These drifted 15 IDs behind before anyone noticed. A small test or CI step that diffs SlackTracerId against the CLI's slacktrace.go could catch the next release for us.

@mwbrooks
mwbrooks merged commit ba1349b into main Nov 17, 2026
22 checks passed
@mwbrooks
mwbrooks deleted the cli-test-latest-traces branch November 17, 2026 05:32
@zimeg

zimeg commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

🌟 Thanks for the kind review @mwbrooks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality pkg:cli-test applies to `@slack/cli-test` semver:minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants