Skip to content

ci: fail the notify job when the announcement is rejected - #238

Merged
zimeg merged 1 commit into
mainfrom
notify-errors-true
Nov 14, 2026
Merged

zimeg merged 1 commit into
mainfrom
notify-errors-true

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

Summary

This pull request sets errors: true on the release announcement step, so a webhook that rejects the post fails the notify job instead of logging an error and staying green.

         uses: slackapi/slack-github-action@dcb1066f776dd043e64d0e8ba94ca15cc7e1875d # v4.0.0
         with:
+          errors: true
           webhook: ${{ secrets.SLACK_RELEASE_ANNOUNCEMENTS_WEBHOOK_URL }}

Requirements

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:58
@zimeg zimeg added this to the Next Release milestone Nov 13, 2026
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.34%. Comparing base (60f2619) to head (88e84d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          11       11           
  Lines        1241     1241           
=======================================
  Hits         1208     1208           
  Misses         33       33           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! A revoked webhook will show up as a red notify job now instead of a quiet log line.

@zimeg

zimeg commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

🩺 Thanks for the kind review @mwbrooks, and for the catch that started this! No more quiet log lines 🔔

@zimeg
zimeg merged commit 1143173 into main Nov 14, 2026
11 of 12 checks passed
@zimeg
zimeg deleted the notify-errors-true branch November 14, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants