Alternative route table and 0.0.0.0 routing #1324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0.0.0.0/0 as possible route
|
Thanks for the contribution! Before we can merge this, we need @dd0ke to sign the Salesforce Inc. Contributor License Agreement. |
JackDoan
reviewed
Feb 13, 2025
| } | ||
|
|
||
| // If it's not a number, look up the table name in /etc/iproute2/rt_tables | ||
| content, err := os.ReadFile("/etc/iproute2/rt_tables") |
There was a problem hiding this comment.
The location of this file seems like it could be distro-specific. Should it be configurable? Can the information instead be obtained via netlink or /proc?
| dst = netip.PrefixFrom(netip.IPv4Unspecified(), 0) | ||
| } else { | ||
| if x := r.Dst.IP.To4(); x == nil { | ||
| // Nebula only handles ipv4 on the overlay currently |
There was a problem hiding this comment.
This comment is technically true, but #6 for IPv6 overlay support is gonna merge any day now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added preliminary support for the creation of routes in alternative route tables on Linux, and using default routes via Nebula.
Nebula would crash anytime a default route was added or modified, regardless of the default route being added on to a separate table.
Requires new config param:
Specify the alternative routing table for created routes.
If unset, defaults to main routing table.
#alternative_routing_table: "my_alt_table"