Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert-v2 group based query protection #1329

Open
wants to merge 3 commits into
base: cert-v2
Choose a base branch
from

Conversation

HenryGrahamRivian
Copy link

@HenryGrahamRivian HenryGrahamRivian commented Feb 13, 2025

This MR introduces an interface for filtering incoming host queries based on groups in the querying host's cert and groups in the queried host's cert.

This will improve the privacy of the network for its users by preventing users from querying hosts that they are not supposed to have access to as defined by the lighthouse configuration.

Required config file additions
lighthouse:
  query_protection:
    test-protection:
      - allowed-group
Example positive interaction

mermaid-diagram-2025-02-14-140947

Example negative interaction

mermaid-diagram-2025-02-14-140746

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Henry Graham <h***@r***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@HenryGrahamRivian HenryGrahamRivian force-pushed the group-based-query-protection branch from 7afdda8 to d84d2f6 Compare February 13, 2025 19:51
Copy link

Thanks for the contribution! Before we can merge this, we need @HenryGrahamRivian to sign the Salesforce Inc. Contributor License Agreement.

@HenryGrahamRivian HenryGrahamRivian marked this pull request as draft February 13, 2025 19:57
@HenryGrahamRivian HenryGrahamRivian marked this pull request as ready for review February 13, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant