Only Run SendSlackMessage From Primary VTorc Instances #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejortegau
reviewed
Feb 5, 2025
| @@ -743,13 +743,17 @@ func executeCheckAndRecoverFunction(analysisEntry *inst.ReplicationAnalysis) (er | |||
| recoveriesCounter.Add(recoveryName, 1) | |||
| if err != nil { | |||
| message := fmt.Sprintf("Recovery failed on %s for problem %s. Error: %s", analysisEntry.AnalyzedInstanceHostname, analysisEntry.Analysis, err.Error()) | |||
| vtopsExec.SendSlackMessage(message, vtopsSlackChannel) | |||
| if analysisEntry.IsPrimary { | |||
There was a problem hiding this comment.
IsPrimary is an attribute of the vtorc analysis (i.e. diagnostic of the problem), not of the vtorc instance itself. So with this change, the recovery messages would only be used for primary vttablets, bout would still be sent by all vtorcs. Unlike classical Orchestrator, in vtorc there are no cluster leaders/primaries, they all operate independently of each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently VTorc sends 3x slack notifications when recovery succeeds or fails. This PR limits those messages to only be from the primary vtorc instances.
Related Issue(s)
Checklist
Deployment Notes