Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paper.md #47

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Update paper.md #47

merged 1 commit into from
Apr 1, 2025

Conversation

fkhosrawi
Copy link
Collaborator

Farah's corrections implemented.

Pull Request Template

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • Test 1
  • Test 2

Checklist:

  • I have updated the documentation accordingly (if applicable).
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes (if applicable).
  • All new and existing tests passed.

Screenshots (if applicable)

Additional Notes

Farah's corrections implemented.
@fkhosrawi
Copy link
Collaborator Author

Hi Lars,

ich habe einen Teil meiner Korrekturvorschläge direkt im github Dokument eingefügt. Zusätzliche Kommentare, die ich noch hätte, sind die folgenden:

L20: "real-world scenario"-> der Begriff gefällt mir nicht so gut. Lässt sich das irgendwie anders schreiben?

L41-42: Der erste Satz im Abschnitt "Features" ist meiner Meinung nach überflüssig. Genau das wurde ja schon im "Summary" und "Statement of need" gesagt. Hier reicht es doch eigentlich auf die spezfischen Module und Eigenschaften von MPTRAC einzugehen.

L55: Hier wäre es sinnvoll auch die unterstützten Datenformate (ascii, netcdf, vtk etc.) zu nennen.

Abschnitt "Evolution and Future Directions": Ich finde Jupiter und Exascale könnte etwas stärker betont werden.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (cb1fdab) to head (68e515b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files          27       27           
  Lines        6788     6788           
  Branches      127      127           
=======================================
  Hits         5792     5792           
  Misses        996      996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lars2015 lars2015 merged commit 19b0af3 into master Apr 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants