donotdisturb: fix fullscreen window detection on Cinnamon #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that it fixes the issue in LM Cinnamon, Ubuntu GNOME, and there is no observable regression in KDE 6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #683.
This broke in #655, where it was not considered that the window under focus could, on X11, be a child window of the actual window, and so the "_NET_WM_STATE" property could be missing. This is the case in Cinnamon, at least for certain windows with focused inputs.
This PR both ensures that we do not crash when the property is missing.
It also switches the detection to find the active window to the "_NET_ACTIVE_WINDOW" property, which is part of EWMH, so older X11 window managers might not support it. However, according to the docs, GTK3 also used that property to get the active window, so this should behave the exact same.