Use pnpm to build the vscode extension #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunger
approved these changes
Aug 21, 2024
NigelBreslaw
force-pushed
the
nigel/vscode-pnpm
branch
from
669c164 to
8bee321
Compare
|
Unfortunately this breaks the vscode extension build. I’ve tried with a few commits this evening, but eventually ran into this: microsoft/vscode-vsce#421 (comment) I suggest to either revert to npm or make one of the workarounds work. |
|
Just to clarify: it’s the vsix creation that fails: https://github.com/slint-ui/slint/actions/runs/10496445625/job/29078000367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.