Skip to content

Various accessibility fixes to Material Design widgets #9918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

Various accessibility fixes to Material Design widgets #9918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui-libraries/material/src/ui/components/filled_icon_button.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export component FilledIconButton {
callback clicked();

accessible-role: button;
accessible-enabled: true;
accessible-enabled: root.enabled;
accessible-label: root.tooltip;
accessible-checkable: root.checkable;
accessible-checked: root.checked;
Expand Down
2 changes: 1 addition & 1 deletion ui-libraries/material/src/ui/components/icon_button.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export component IconButton {
callback clicked();

accessible-role: button;
accessible-enabled: true;
accessible-enabled: root.enabled;
accessible-label: root.tooltip;
accessible-checkable: root.checkable;
accessible-checked: root.checked;
Expand Down
2 changes: 1 addition & 1 deletion ui-libraries/material/src/ui/components/outline_icon_button.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export component OutlineIconButton {
callback clicked();

accessible-role: button;
accessible-enabled: true;
accessible-enabled: root.enabled;
accessible-label: root.tooltip;
accessible-checkable: root.checkable;
accessible-checked: root.checked;
Expand Down
8 changes: 8 additions & 0 deletions ui-libraries/material/src/ui/components/progress_indicator.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ export component LinearProgressIndicator {
in property <float> progress;
in property <bool> indeterminate;

accessible-role: progress-indicator;
accessible-value: !root.indeterminate ? root.progress : "";
accessible-value-minimum: 0.0;
accessible-value-maximum: 1.0;
height: MaterialStyleMetrics.size_4;

Rectangle {
Expand All @@ -34,6 +38,10 @@ export component CircularProgressIndicator {

property <length> bar_height: MaterialStyleMetrics.size_4;

accessible-role: progress-indicator;
accessible-value: !root.indeterminate ? root.progress : "";
accessible-value-minimum: 0.0;
accessible-value-maximum: 1.0;
width: self.height;
min_height: MaterialStyleMetrics.size_40;

Expand Down
19 changes: 17 additions & 2 deletions ui-libraries/material/src/ui/components/slider.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ export component Slider {
accessible-value-minimum: root.minimum;
accessible-value-maximum: root.maximum;
accessible-value-step: min(steps, (root.maximum - root.minimum) / 100);
accessible-action-set-value(v) => {
if v.is-float() {
root.set_value(v.to-float());
}
}
accessible-action-increment => { root.increment_value(); }
accessible-action-decrement => { root.decrement_value(); }
forward-focus: focus_scope;

focus_scope := FocusScope {
Expand Down Expand Up @@ -107,11 +114,11 @@ export component Slider {

key_pressed(event) => {
if event.text == Key.LeftArrow {
root.set_value(root.value - root.steps);
root.decrement_value();
return accept;
}
if event.text == Key.RightArrow {
root.set_value(root.value + root.steps);
root.increment_value();
return accept;
}
reject
Expand All @@ -137,4 +144,12 @@ export component Slider {
root.value = clamp(value, root.minimum, root.maximum)
}
}

function increment_value() {
root.set_value(root.value + root.steps);
}

function decrement_value() {
root.set_value(root.value - root.steps);
}
}
2 changes: 1 addition & 1 deletion ui-libraries/material/src/ui/components/switch.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export component Switch {
accessible-enabled: root.enabled;
accessible-checkable: true;
accessible-checked <=> root.checked;
accessible-role: checkbox;
accessible-role: switch;
accessible-action-default => { touch_area.clicked(); }
forward_focus: touch_area;

Expand Down
2 changes: 1 addition & 1 deletion ui-libraries/material/src/ui/components/tonal_icon_button.slint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export component TonalIconButton {
callback clicked();

accessible-role: button;
accessible-enabled: true;
accessible-enabled: root.enabled;
accessible-label: root.tooltip;
accessible-checkable: root.checkable;
accessible-checked: root.checked;
Expand Down
Loading