fix solution previewing #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malerba118 is attempting to deploy a commit to the Sliphq Team on Vercel. A member of the Team first needs to authorize it. |
|
Closing because #15 included these fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRing against the include-solution branch so can see diff between the two branches better.
This modifies the sql script to init the db because it was a bit broken/out of date (ideally should use migration for this, but probably ok in this case).
Because we're adding a solution column to the quizzes table, any existing rows will have null solutions. For these quizzes with no solution the "Show Solution" button is not rendered.
This also fixes solution previewing and makes solutions readonly. The use of refs here is a bit unconventional and in some cases is causing ui to get out of sync with the app state. The simplest fix was to put in a force rerender while reseting the code to its starting state. Ideally, should just use state instead of refs to store code and won't run into these out-of-sync bugs.