Add uberon_id check for tissue #371
Conversation
There was a problem hiding this comment.
I think this looks fine though I wonder how controlled the external_id is. It appears to assume a hyphen separating 2 'meaningful' values? From what I can tell the schema nor tissue validators check that this is the case? Maybe it's there and I missed it as things are so spread around in utils etc. Probably not a big deal but seems like there could be possibility of exceptions being thrown by some of the utils functions if for example there is not a hyphen.
| def get_valid_protocol_ids(properties: Dict[str, Any]) -> str: | ||
| """Get valid_protocol_ids from properties.""" | ||
| return properties.get("valid_protocol_ids","") |
There was a problem hiding this comment.
Shouldn't the default get result be an empty array?
|
@aschroed Thanks for your comments! That is a great point. I added checks to Tissue and Donor to make sure that |
valid_protocol_idsto OntologyTerm that is a list of protocol IDs (e.g. 1D, 3A), the portion ofexternal_idindicating tissue types defined hereexternal_idis among thevalid_protocol_idsfor the OntologyTerm linked withuberon_idexternal_idmatches expected format for Benchmarking and Productionexternal_ida required property for Donor