Skip to content

Only enable JFR if a specific property is set #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmlloyd merged 1 commit into from
Sep 9, 2026
Merged

Only enable JFR if a specific property is set #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions runtime/src/main/java/io/smallrye/modules/ModuleClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import io.smallrye.modules.impl.Util;
import io.smallrye.modules.jfr.DefineDuplicateEvent;
import io.smallrye.modules.jfr.DefineFailedEvent;
import io.smallrye.modules.jfr.JfrSupport;
import io.smallrye.modules.jfr.LinkEvent;

/**
Expand Down Expand Up @@ -664,8 +665,9 @@ LinkState.Dependencies linkDependencies() {
if (linkState instanceof LinkState.Dependencies dependencies) {
return dependencies;
}
LinkEvent event = new LinkEvent();
if (event.isEnabled()) {
LinkEvent event;
if (JfrSupport.ENABLED) {
event = new LinkEvent();
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
event.linkStage = "dependencies";
Expand Down Expand Up @@ -736,8 +738,9 @@ LinkState.Defined linkDefined() {
if (linkState instanceof LinkState.Defined defined) {
return defined;
}
LinkEvent event = new LinkEvent();
if (event.isEnabled()) {
LinkEvent event;
if (JfrSupport.ENABLED) {
event = new LinkEvent();
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
event.linkStage = "defined";
Expand Down Expand Up @@ -834,11 +837,12 @@ LinkState.Packages linkPackages() {
if (linkState instanceof LinkState.Packages packages) {
return packages;
}
LinkEvent event = new LinkEvent();
if (event.isEnabled()) {
LinkEvent event;
if (JfrSupport.ENABLED) {
event = new LinkEvent();
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
event.linkStage = "dependencies";
event.linkStage = "packages";
event.begin();
} else {
event = null;
Expand Down Expand Up @@ -1000,8 +1004,9 @@ LinkState.Provides linkProvides() {
if (linkState instanceof LinkState.Provides provides) {
return provides;
}
LinkEvent event = new LinkEvent();
if (event.isEnabled()) {
LinkEvent event;
if (JfrSupport.ENABLED) {
event = new LinkEvent();
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
event.linkStage = "provides";
Expand Down Expand Up @@ -1056,8 +1061,9 @@ LinkState.Uses linkUses() {
if (linkState instanceof LinkState.Uses uses) {
return uses;
}
LinkEvent event = new LinkEvent();
if (event.isEnabled()) {
LinkEvent event;
if (JfrSupport.ENABLED) {
event = new LinkEvent();
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
event.linkStage = "uses";
Expand Down Expand Up @@ -1179,8 +1185,8 @@ private Class<?> defineOrGetClass(final String binaryName, final ByteBuffer buff
return defineClass(binaryName, buffer, pd);
} catch (VerifyError e) {
// serious problem!
DefineFailedEvent event = new DefineFailedEvent();
if (event.isEnabled()) {
if (JfrSupport.ENABLED) {
DefineFailedEvent event = new DefineFailedEvent();
event.className = binaryName;
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
Expand All @@ -1192,18 +1198,18 @@ private Class<?> defineOrGetClass(final String binaryName, final ByteBuffer buff
// probably a duplicate
Class<?> loaded = findLoadedClass(binaryName);
if (loaded != null) {
DefineDuplicateEvent event = new DefineDuplicateEvent();
if (event.isEnabled()) {
if (JfrSupport.ENABLED) {
DefineDuplicateEvent event = new DefineDuplicateEvent();
event.className = binaryName;
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
event.commit();
}
return loaded;
}
// actually some other problem
DefineFailedEvent event = new DefineFailedEvent();
if (event.isEnabled()) {
if (JfrSupport.ENABLED) {
// actually some other problem
DefineFailedEvent event = new DefineFailedEvent();
event.className = binaryName;
event.moduleName = moduleName;
event.moduleVersion = moduleVersion;
Expand Down
12 changes: 12 additions & 0 deletions runtime/src/main/java/io/smallrye/modules/jfr/JfrSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package io.smallrye.modules.jfr;

public final class JfrSupport {
private JfrSupport() {
}

public static final boolean ENABLED;

static {
ENABLED = Boolean.parseBoolean(System.getProperty("io.smallrye.modules.jfr", "false"));
}
}
Loading