ci: bump setup-node to Node 22 across all workflows#546
Merged
Conversation
The v0.34.0 release failed when the windows-arm64 build job's setup-node step could not download Node 20. windows-latest is migrating to the windows-2025 runner image, which no longer pre-installs Node 20 in the hosted toolcache; setup-node v6 then falls back to downloading it, which is unreliable (the amd64 job landed on an image that still had Node 20 cached and passed; the arm64 job did not and failed). Node 20 was also inconsistent with the project's own requirements: frontend/package.json engines is >=22.18.0 and frontend/.nvmrc pins 22. Pinning CI to Node 22 (current LTS, present in the 2025 toolcache) removes the flaky download path and matches local dev.
Deploying mcpproxy-docs with
|
| Latest commit: |
5cf7330
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0833d49.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://chore-ci-node22.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26674758673 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.34.0 release run failed: the
build (windows, arm64)job's Setup Node.js step died right afterAttempting to download 20....Root cause
windows-latestis migrating to the windows-2025 runner image, which no longer pre-installs Node 20 in the hosted toolcache.actions/setup-node@v6falls back to downloading it — an unreliable path. The amd64 Windows job happened to land on an image that still had Node 20 cached and passed; the arm64 job did not and failed.frontend/package.jsonengines is>=22.18.0andfrontend/.nvmrcalready pins22.Fix
Pin every workflow's
node-versionto 22 (current LTS, present in the 2025 toolcache). This removes the flaky download path and matches local dev.Files touched:
release.yml(×2),prerelease.yml,frontend.yml,pr-build.yml,unit-tests.yml,e2e-tests.yml,docs.yml.Note on v0.34.0
I also re-ran the failed jobs of the original release run to attempt an immediate unblock. If that re-run lands on another Node-20-less image and fails again, re-cut the tag once this is merged.