fix(frontend): rebind server-edition settings to server_edition.* key (MCP-1087)#671
Closed
Dumbris wants to merge 1 commit into
Closed
fix(frontend): rebind server-edition settings to server_edition.* key (MCP-1087)#671Dumbris wants to merge 1 commit into
Dumbris wants to merge 1 commit into
Conversation
… (MCP-1087)
MCP-1086 (backend rename teams->server_edition) has now landed. Flip the
frontend settings binding from the legacy teams.* dot-paths to the canonical
server_edition.* paths, and add aliasServerEdition() in Settings.vue so old
configs that still carry the teams key still hydrate the form.
- settings/fields.ts: teams.{enabled,oauth.provider,max_user_servers}
-> server_edition.{...}
- Settings.vue: hasTeams -> hasServerEdition computed (gates on
server_edition != null || teams != null); aliasServerEdition() applied
at loadConfig so legacy configs hydrate without a tab-disappear regression
- Unit test: update assertion from ^teams\. to ^server_edition\. now that
the backend contract has landed
Verified: vitest 142/142, make build.
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Deploying mcpproxy-docs with
|
| Latest commit: |
33f1db7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52b5122b.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://mcp-1087-fe-server-edition-k.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCP-1086 (backend rename `teams` → `server_edition`) merged in PR #603. This PR flips the frontend settings binding from the legacy `teams.` dot-paths to the canonical `server_edition.` paths.
Changes:
Verified: vitest 142/142 pass, `make build` clean.
Closes MCP-1087