fix(serveredition): move orphaned OAuth broker connector to fix Server Edition CI#678
Closed
Dumbris wants to merge 1 commit into
Closed
fix(serveredition): move orphaned OAuth broker connector to fix Server Edition CI#678Dumbris wants to merge 1 commit into
Dumbris wants to merge 1 commit into
Conversation
…dition package The teams→serveredition rename (MCP-1086) moved credential_store.go, bbolt_aes.go and token_exchanger.go into internal/serveredition/broker but left oauth_connector.go + its test behind in internal/teams/broker. That orphaned package referenced CredentialStore/UpstreamCredential (now in serveredition/broker) by their old same-package names, so internal/teams/broker no longer compiled under -tags server and broke the "Server Edition" CI job on main, blocking every server-edition merge. Move oauth_connector.go and oauth_connector_test.go into internal/serveredition/broker (same package name, where the moved types and the test helpers newTestStore/newTestKey live) and remove the now-empty internal/teams tree. Update the unit-tests workflow's server-edition step to test ./internal/serveredition/... since ./internal/teams/... no longer exists (it was hard-failing with "no such file or directory"). Verified: go build (personal + server), go test -race -tags server ./internal/serveredition/... ./internal/config/..., and golangci-lint v2.5.0 all green. Related #672 Related MCP-2455
Deploying mcpproxy-docs with
|
| Latest commit: |
6028610
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db6f0fd2.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-mcp-2455-teams-broker-se.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 27523116833 --repo smart-mcp-proxy/mcpproxy-go
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Server Edition CI job (
unit-tests.yml→ Test server edition packages) is red onmain(9f3e1abf), blocking every server-edition merge (surfaced by #672 / MCP-2442):Root cause
The teams→serveredition rename (MCP-1086, #602) moved
credential_store.go,bbolt_aes.goandtoken_exchanger.gointointernal/serveredition/broker/but leftoauth_connector.go+ its test orphaned ininternal/teams/broker/. That package referencedCredentialStore/UpstreamCredential(now inserveredition/broker) by their old same-package names, and its test referenced helpers (newTestStore/newTestKey) that also moved → theinternal/teams/brokerpackage no longer compiles under-tags server.oauth_connector.go(spec 074 Path B,OAuthConnector) is unique functionality — not duplicated inserveredition/broker, and imported by nothing outside its own package — so the correct fix is to complete the rename, not delete it.Fix
git mvoauth_connector.go+oauth_connector_test.gointointernal/serveredition/broker/(samepackage broker, where the moved types and test helpers live); remove the now-emptyinternal/teamstree.unit-tests.ymlserver-edition step to test./internal/serveredition/...— the old./internal/teams/...path no longer exists and was itself hard-failing withno such file or directory.Verification
go build ./cmd/mcpproxy(personal) ✅go build -tags server ./cmd/mcpproxy✅go test -race -tags server ./internal/serveredition/... ./internal/config/...— all packagesok✅golangci-lint v2.5.0 --config .github/.golangci.yml(server tags) — 0 issues ✅Related #672
Related MCP-2455