Skip to content

ci(release): restore prerelease guard on retry update-homebrew/publish-linux-repos (MCP-3020)#737

Open
Dumbris wants to merge 1 commit into
fix/mcp-2905-retry-sign-release-artifact-patternsfrom
fix/mcp-3020-prerelease-guard
Open

ci(release): restore prerelease guard on retry update-homebrew/publish-linux-repos (MCP-3020)#737
Dumbris wants to merge 1 commit into
fix/mcp-2905-retry-sign-release-artifact-patternsfrom
fix/mcp-3020-prerelease-guard

Conversation

@Dumbris

@Dumbris Dumbris commented Jun 20, 2026

Copy link
Copy Markdown
Member

Problem

retry-sign-release.yml's newly-added update-homebrew and publish-linux-repos jobs (PR #718) only check github.repository but lack the stable-tag guard present in release.yml:

# release.yml
if: startsWith(github.ref, 'refs/tags/v') && !contains(github.ref_name, '-') && github.repository == '...'

Running the retry workflow for an RC tag (e.g. v1.2.0-rc.1) would push to the stable Homebrew tap and apt/rpm repos.

Fix

Add !contains(inputs.tag, '-') to both job if: conditions (using inputs.tag since the retry workflow is workflow_dispatch-only and github.ref_name is always the default branch there):

-    if: github.repository == 'smart-mcp-proxy/mcpproxy-go'
+    if: github.repository == 'smart-mcp-proxy/mcpproxy-go' && !contains(inputs.tag, '-')

Applies to both update-homebrew (line 402) and publish-linux-repos (line 588).

Testing

CI workflow — no runtime test possible without a real RC signing scenario. Logic is a single boolean expression parity-check against release.yml.

Fast-follow flagged during PR #718 review. Closes MCP-3020.

…brew/publish-linux-repos

Restores parity with release.yml's prerelease exclusion on the two
distribution jobs.  Running the retry workflow for an RC tag (e.g.
v1.2.0-rc.1) would otherwise push to the stable Homebrew tap and the
apt/rpm repos.

Fast-follow for MCP-3020; part of MCP-2905 / PR #718.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a7bc0b
Status: ✅  Deploy successful!
Preview URL: https://cfb9c59e.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-mcp-3020-prerelease-guar.mcpproxy-docs.pages.dev

View logs

@mcpproxy-gatekeeper mcpproxy-gatekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatekeeper approval — Codex review verdict: ACCEPT.

This approval is posted automatically by the MCPProxy Gatekeeper App on behalf of the Codex reviewer (verdict of record lives in the Paperclip review thread). Author≠approver satisfied; QA + CI gates enforced separately.

Auto-approved per Model B (MCP-1249).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant