ci(release): restore prerelease guard on retry update-homebrew/publish-linux-repos (MCP-3020)#737
Open
Dumbris wants to merge 1 commit into
Conversation
…brew/publish-linux-repos Restores parity with release.yml's prerelease exclusion on the two distribution jobs. Running the retry workflow for an RC tag (e.g. v1.2.0-rc.1) would otherwise push to the stable Homebrew tap and the apt/rpm repos. Fast-follow for MCP-3020; part of MCP-2905 / PR #718. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Deploying mcpproxy-docs with
|
| Latest commit: |
9a7bc0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cfb9c59e.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-mcp-3020-prerelease-guar.mcpproxy-docs.pages.dev |
There was a problem hiding this comment.
✅ Gatekeeper approval — Codex review verdict: ACCEPT.
This approval is posted automatically by the MCPProxy Gatekeeper App on behalf of the Codex reviewer (verdict of record lives in the Paperclip review thread). Author≠approver satisfied; QA + CI gates enforced separately.
Auto-approved per Model B (MCP-1249).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
retry-sign-release.yml's newly-addedupdate-homebrewandpublish-linux-reposjobs (PR #718) only checkgithub.repositorybut lack the stable-tag guard present inrelease.yml:Running the retry workflow for an RC tag (e.g.
v1.2.0-rc.1) would push to the stable Homebrew tap and apt/rpm repos.Fix
Add
!contains(inputs.tag, '-')to both jobif:conditions (usinginputs.tagsince the retry workflow isworkflow_dispatch-only andgithub.ref_nameis always the default branch there):Applies to both
update-homebrew(line 402) andpublish-linux-repos(line 588).Testing
CI workflow — no runtime test possible without a real RC signing scenario. Logic is a single boolean expression parity-check against
release.yml.Fast-follow flagged during PR #718 review. Closes MCP-3020.