Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogPoller support for MaxLogsKept #1338

Open
wants to merge 7 commits into
base: ccip-develop
Choose a base branch
from
Open

LogPoller support for MaxLogsKept #1338

wants to merge 7 commits into from

Commits on Sep 11, 2024

  1. - Add DeleteExcessLogs(), benchmarks for that, and DeleteExpiredLogs(… 

    …) with limit=1000

- Add id column as PRIMARY KEY for evm.logs & evm.log_poller_blocks
- Add UNIQUE INDEXes to replace previous primary keys
- Set MaxLogsKept = 1 for contract transmitter
- Add logging of when pruning happens and whether it was fully completed
    @reductionista
    reductionista committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    bdc5bbb View commit details
    Browse the repository at this point in the history

  2. Split DeleteExcessLogs into FindExcessLogs & DeleteLogsByRowIds 

    Also, add WithMaxLogsKept
    @reductionista
    reductionista committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    33126e6 View commit details
    Browse the repository at this point in the history

  3. Log error if FindExcessLogs fails

    @reductionista
    reductionista committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8064882 View commit details
    Browse the repository at this point in the history

  4. Fix inverted logic for determining if log pruning is incomplete

    @reductionista
    reductionista committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c1ad867 View commit details
    Browse the repository at this point in the history

  5. Increase MaxLogsKept to 50

    @reductionista
    reductionista committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    43c542d View commit details
    Browse the repository at this point in the history

  6. Lower LogPrunePageSize from default 10,000 to 1500 

    With present settings, it's running once every 40 mins and deleting
around 3200 logs. This only takes a few seconds, but appears to be
slowing down other queries a bit when it happens. Cutting this down
to 1500 will hopefully keep it more stable.
    @reductionista
    reductionista committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c884ea7 View commit details
    Browse the repository at this point in the history

  7. Lower LogPrunePageSize a bit further to 999

    @reductionista
    reductionista committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    49648cc View commit details
    Browse the repository at this point in the history