LogPoller prune test #1351
Draft
LogPoller prune test #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing duplicate rows to get inserted during a replay instead of it being an UPDATE
mateusz-sekara
commented
Aug 22, 2024
| @@ -658,7 +658,7 @@ func (lp *logPoller) backgroundWorkerRun() { | |||
| } | |||
| case <-logPruneTick: | |||
| lp.lggr.Infof("Pruning LogPoller logs...") | |||
| logPruneTick = time.After(utils.WithJitter(lp.pollPeriod * 2401)) // = 7^5 avoids common factors with 1000 | |||
| logPruneTick = time.After(utils.WithJitter(5 * time.Minute)) // = 7^5 avoids common factors with 1000 | |||
There was a problem hiding this comment.
Ignoring poll period only to test
mateusz-sekara
commented
Aug 22, 2024
| @@ -443,7 +443,8 @@ func NewCommitStore(lggr logger.Logger, addr common.Address, ec client.Client, l | |||
| Name: logpoller.FilterName(v1_0_0.EXEC_REPORT_ACCEPTS, addr.String()), | |||
| EventSigs: []common.Hash{eventSig}, | |||
| Addresses: []common.Address{addr}, | |||
| Retention: ccipdata.CommitExecLogsRetention, | |||
| //Retention: ccipdata.CommitExecLogsRetention, | |||
| MaxLogsKept: 10, | |||
There was a problem hiding this comment.
This is probably going to break the tests, because it's too aggressive. I set that intentionally to enforce more freq prunes
|
reductionista
force-pushed
the
max-logs-kept-tests
branch
2 times, most recently
from
814b898
to
0a76672
Compare
reductionista
force-pushed
the
max-logs-kept-tests
branch
4 times, most recently
from
e4aa477
to
6164cd5
Compare
reductionista
force-pushed
the
max-logs-kept-tests
branch
from
bfc8e26
to
49648cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution