Self Serve Token Pool Factory Contract #1410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhweintraub
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
LCOV of commit
|
RyanRHall
reviewed
Sep 17, 2024
contracts/src/v0.8/ccip/test/tokenAdminRegistry/TokenPoolFactory.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/tokenAdminRegistry/TokenPoolFactory.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/tokenAdminRegistry/TokenPoolFactory.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/tokenAdminRegistry/TokenPoolFactory.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/tokenAdminRegistry/TokenPoolFactory.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/tokenAdminRegistry/TokenPoolFactory.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/tokenAdminRegistry/TokenPoolFactory.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/tokenAdminRegistry/TokenPoolFactory.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/shared/util/DeterministicContractDeployer.sol
Outdated
Show resolved
Hide resolved
jhweintraub
force-pushed
the
feature/selfServeFactory
branch
from
5b3af81
to
9355849
Compare
jhweintraub
force-pushed
the
feature/selfServeFactory
branch
from
299daec
to
9355849
Compare
jhweintraub
force-pushed
the
feature/selfServeFactory
branch
from
f7c97f0
to
9355849
Compare
RyanRHall
suggested changes
Oct 15, 2024
contracts/src/v0.8/ccip/interfaces/IRegistryModuleOwnerCustom.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/interfaces/IRegistryModuleOwnerCustom.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/tokenAdminRegistry/FactoryBurnMintERC20.t.sol
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,461 @@ | |||
| pragma solidity ^0.8.24; | |||
There was a problem hiding this comment.
I think this comment still applies ☝️
contracts/src/v0.8/ccip/test/tokenAdminRegistry/FactoryBurnMintERC20.t.sol
Outdated
Show resolved
Hide resolved
RyanRHall
suggested changes
Oct 21, 2024
contracts/src/v0.8/ccip/test/tokenAdminRegistry/FactoryBurnMintERC20.t.sol
Outdated
Show resolved
Hide resolved
Comment on lines
+35
to
+40
| string memory name = "Chainlink token v2"; | ||
| string memory symbol = "LINK2"; | ||
| uint8 decimals = 19; | ||
| uint256 maxSupply = 1e33; | ||
|
|
||
| s_burnMintERC20 = new FactoryBurnMintERC20(name, symbol, decimals, maxSupply, 1e18, s_alice); |
There was a problem hiding this comment.
nit: I feel like we could just assert against the contract deployed in the setup() function, rather than deploying a new one
There was a problem hiding this comment.
I could've sworn that coverage tests don't apply to the setup function which is why there's always a testConstructorSuccess() function
contracts/src/v0.8/ccip/test/tokenAdminRegistry/FactoryBurnMintERC20.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/test/tokenAdminRegistry/TokenPoolFactory.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/ccip/tokenAdminRegistry/TokenPoolFactory/FactoryBurnMintERC20.sol
Outdated
Show resolved
Hide resolved
| RemoteChainConfig memory remoteChainConfig, | ||
| address remoteTokenAddress, | ||
| PoolType poolType | ||
| ) internal pure virtual returns (bytes32) { |
There was a problem hiding this comment.
can this be made private?
There was a problem hiding this comment.
Not if we want to make it virtual, which I kept in there for potential modifications and inheritance in the next version of the contract which is deprioritized until next year. I'm not sure if we will need it to be that way or not but I prefer to keep it instead of foreclosing the possibility.
contracts/src/v0.8/shared/token/ERC677/OpStackBurnMintERC677.sol
Outdated
Show resolved
Hide resolved
RyanRHall
suggested changes
Oct 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To better ease the process of deploying and configuring self-serve token pools, a factory contract has been deployed which will deploy the tokens, pools, etc. and configure them with the token admin registry. This reduces the number of transactions the end user must make to configure a pool from >12 to ~3-4.