typeconv: Implement for Solana #619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
archseer
force-pushed
the
solana-typeconv
branch
from
fa7ffc1 to
39337c1
Compare
| switch family { | ||
| case chainsel.FamilyEVM: | ||
| // TODO: not EIP-55. Fix this? | ||
| return "0x" + hex.EncodeToString(addr) |
There was a problem hiding this comment.
Just use hexutil.Encode(addr)
It encodes the bytes as a hex string with 0x prefix
Its a geth library from:
"github.com/ethereum/go-ethereum/common/hexutil"
There was a problem hiding this comment.
@prashantkumar1982 this probably needs to be another service.
| switch family { | ||
| case chainsel.FamilyEVM: | ||
| // lower case in case EIP-55 and trim 0x prefix if there | ||
| addrBytes, err := hex.DecodeString(strings.ToLower(strings.TrimPrefix(addr, "0x"))) |
There was a problem hiding this comment.
common.HexToAddress(addr)
Import "github.com/ethereum/go-ethereum/common"
winder
reviewed
Feb 18, 2025
| @@ -4,6 +4,7 @@ go 1.23.3 | |||
|
|
|||
| require ( | |||
| github.com/deckarep/golang-set/v2 v2.6.0 | |||
| github.com/gagliardetto/solana-go v1.12.0 | |||
There was a problem hiding this comment.
This dependency is a non starter.
winder
requested changes
Feb 18, 2025
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.