[Solana] Optional merkle_root on commit accepted event #639
Conversation
PabloMansanet
changed the title
|
| // Will be zero'd (MerkleRoot::Default() in case the commit report included no | ||
| // merkle root. This is to circumvent a Go deserialization issue.) | ||
| pub merkle_root: MerkleRoot, | ||
| pub merkle_root: Option<MerkleRoot>, |
There was a problem hiding this comment.
We need to communicate this change with the following teams:
- Chain Reader
- Log Poller
- Observability
There was a problem hiding this comment.
Let's chat about it offline, I'm not fully aware yet of the channels/people through which to communicate changes like this.
There was a problem hiding this comment.
I've requested this change to fix decoding the report in CR/offchain so LGTM 👍🏻
| } | ||
|
|
||
| // This event uses bespoke parsing, as it contains an `Optional` field which cannot be unmarshalled through `bin.UnmarshalBorsh` | ||
| func ParseEventCommitReportAccepted(logs []string, event string, obj *EventCommitReportAccepted) error { |
There was a problem hiding this comment.
can you add a comment here on why we need to do this differently?
There was a problem hiding this comment.
Is the comment in line 85 not sufficient? It was my intention to explain it with that comment 🙂 (plus the one in ParseEvent which describes why it won't work with events that have an Option).
If you are asking about the root cause, something is just not right in the borsh decoder implementation of the gagliardetto/bin library, and it doesn't particularly seem worth the time to investigate it further.
No description provided.