[KS-370] Add ConfigForCapability to CapabilitiesRegistry (#640)

* [KS-370] Add ConfigForCapability to CapabilityRegistry

* Address feedback: use durationpb rather than uint32

* Rename ExecuteConfig -> DefaultConfig

* Add IsLocal to capabilityInfo

* Add IsLocal to CapabilityInfo

* Rename GetLocalNode -> LocalNode

* Fix MustNewCapabilityInfo

* Pass through IsLocal to GRPC call

pkg/capabilities/capabilities.go

@@ -218,6 +218,7 @@ type CapabilityInfo struct {
 	CapabilityType CapabilityType
 	Description    string
 	DON            *DON
+	IsLocal        bool
 }
 
 // Parse out the version from the ID.
@@ -250,24 +251,12 @@ const (
 	idMaxLength = 128
 )
 
-// NewCapabilityInfo returns a new CapabilityInfo.
-func NewCapabilityInfo(
-	id string,
-	capabilityType CapabilityType,
-	description string,
-) (CapabilityInfo, error) {
-	return NewRemoteCapabilityInfo(id, capabilityType, description, nil)
-}
-
-// NewRemoteCapabilityInfo returns a new CapabilityInfo for remote capabilities.
-// This is largely intended for internal use by the registry syncer.
-// Capability developers should use `NewCapabilityInfo` instead as this
-// omits the requirement to pass in the DON Info.
-func NewRemoteCapabilityInfo(
+func newCapabilityInfo(
 	id string,
 	capabilityType CapabilityType,
 	description string,
 	don *DON,
+	isLocal bool,
 ) (CapabilityInfo, error) {
 	if len(id) > idMaxLength {
 		return CapabilityInfo{}, fmt.Errorf("invalid id: %s exceeds max length %d", id, idMaxLength)
@@ -285,17 +274,45 @@ func NewRemoteCapabilityInfo(
 		CapabilityType: capabilityType,
 		Description:    description,
 		DON:            don,
+		IsLocal:        isLocal,
 	}, nil
 }
 
+// NewCapabilityInfo returns a new CapabilityInfo.
+func NewCapabilityInfo(
+	id string,
+	capabilityType CapabilityType,
+	description string,
+) (CapabilityInfo, error) {
+	return newCapabilityInfo(id, capabilityType, description, nil, true)
+}
+
+// NewRemoteCapabilityInfo returns a new CapabilityInfo for remote capabilities.
+// This is largely intended for internal use by the registry syncer.
+// Capability developers should use `NewCapabilityInfo` instead as this
+// omits the requirement to pass in the DON Info.
+func NewRemoteCapabilityInfo(
+	id string,
+	capabilityType CapabilityType,
+	description string,
+	don *DON,
+) (CapabilityInfo, error) {
+	return newCapabilityInfo(id, capabilityType, description, don, false)
+}
+
 // MustNewCapabilityInfo returns a new CapabilityInfo,
 // `panic`ing if we could not instantiate a CapabilityInfo.
 func MustNewCapabilityInfo(
 	id string,
 	capabilityType CapabilityType,
 	description string,
 ) CapabilityInfo {
-	return MustNewRemoteCapabilityInfo(id, capabilityType, description, nil)
+	c, err := NewCapabilityInfo(id, capabilityType, description)
+	if err != nil {
+		panic(err)
+	}
+
+	return c
 }
 
 // MustNewRemoteCapabilityInfo returns a new CapabilityInfo,
@@ -367,3 +384,35 @@ outerLoop:
 
 	return &values.List{Underlying: vs}, nil
 }
+
+const (
+	DefaultRegistrationRefresh = 30 * time.Second
+	DefaultRegistrationExpiry  = 2 * time.Minute
+	DefaultMessageExpiry       = 2 * time.Minute
+)
+
+type RemoteTriggerConfig struct {
+	RegistrationRefresh     time.Duration
+	RegistrationExpiry      time.Duration
+	MinResponsesToAggregate uint32
+	MessageExpiry           time.Duration
+}
+
+// NOTE: consider splitting this config into values stored in Registry (KS-118)
+// and values defined locally by Capability owners.
+func (c *RemoteTriggerConfig) ApplyDefaults() {
+	if c.RegistrationRefresh == 0 {
+		c.RegistrationRefresh = DefaultRegistrationRefresh
+	}
+	if c.RegistrationExpiry == 0 {
+		c.RegistrationExpiry = DefaultRegistrationExpiry
+	}
+	if c.MessageExpiry == 0 {
+		c.MessageExpiry = DefaultMessageExpiry
+	}
+}
+
+type CapabilityConfiguration struct {
+	DefaultConfig       *values.Map
+	RemoteTriggerConfig RemoteTriggerConfig
+}

pkg/capabilities/pb/capabilities.proto

@@ -24,6 +24,7 @@ message CapabilityInfoReply {
   CapabilityType capability_type = 2;
   string description = 3;
   string version = 4;
+  bool isLocal = 5;
 }
 
 message RequestMetadata {

pkg/capabilities/pb/generate.go

@@ -1,2 +1,3 @@
 //go:generate protoc --go_out=../../ --go_opt=paths=source_relative --go-grpc_out=../../ --go-grpc_opt=paths=source_relative --proto_path=../../ capabilities/pb/capabilities.proto values/pb/values.proto
+//go:generate protoc --go_out=../../ --go_opt=paths=source_relative --go-grpc_out=../../ --go-grpc_opt=paths=source_relative --proto_path=../../ capabilities/pb/registry.proto values/pb/values.proto
 package pb