(feat): Cron Trigger Service Capability #715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Failure
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
commented
Aug 20, 2024
justinkaseman
changed the base branch from
main
to
CAPPL-6-formalize-trigger-API
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Failure
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Failure
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
force-pushed
the
CAPPL-6-formalize-trigger-API
branch
3 times, most recently
from
0e45846
to
520700c
Compare
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Failure
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
force-pushed
the
CAPPL-6-formalize-trigger-API
branch
from
2de0101
to
6c234bb
Compare
jmank88
reviewed
Aug 24, 2024
cedric-cordenier
force-pushed
the
CAPPL-6-formalize-trigger-API
branch
2 times, most recently
from
1204573
to
5b2a911
Compare
cedric-cordenier
force-pushed
the
CAPPL-6-formalize-trigger-API
branch
from
5b2a911
to
6a3d104
Compare
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Error
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Error
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Error
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Failure
justinkaseman
temporarily deployed
to
integration
GitHub Actions
Inactive
justinkaseman
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
reviewed
Aug 26, 2024
| "encoding/hex" | ||
| ) | ||
|
|
||
| func GenerateExecutionID(workflowID, eventID string) (string, error) { |
There was a problem hiding this comment.
nit/ Generate feels like a strong word for hash + hex encode. What about something like Encode?
Suggested change
| func GenerateExecutionID(workflowID, eventID string) (string, error) { | |
| func EncodeExecutionID(workflowID, eventID string) (string, error) { |
Also, you can probably eliminate the error from the signature if you wanted to, since the hash impl used does not return errors and is just satisfying the interface.
There was a problem hiding this comment.
For comparison:
Suggested change
| func GenerateExecutionID(workflowID, eventID string) (string, error) { | |
| func NewExecutionID(workflowID, eventID string) string { |
Suggested change
| func GenerateExecutionID(workflowID, eventID string) (string, error) { | |
| func EncodeExecutionID(workflowID, eventID string) string { |
There was a problem hiding this comment.
Suggested change
| func GenerateExecutionID(workflowID, eventID string) (string, error) { | |
| func DeriveExecutionID(workflowID, eventID string) string { |
cedric-cordenier
force-pushed
the
CAPPL-6-formalize-trigger-API
branch
from
a09f782
to
d31e448
Compare
|
Superceded by Capabilities PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a new trigger capability for scheduling workflows via a Cron schedule.