-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chain Reader Unstarted tests #777
Draft
ilija42
wants to merge
2
commits into
main
Choose a base branch
from
BCI-3989-cr-methods-error-when-unstarted-alt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
had a problem deploying
to
integration
September 18, 2024 13:35
— with
GitHub Actions
Failure
ilija42
force-pushed
the
BCI-3989-cr-methods-error-when-unstarted-alt
branch
from
September 18, 2024 13:40
f5a5022
to
201f1dc
Compare
ilija42
had a problem deploying
to
integration
September 18, 2024 13:41
— with
GitHub Actions
Failure
ilija42
had a problem deploying
to
integration
September 18, 2024 13:45
— with
GitHub Actions
Failure
ilija42
force-pushed
the
BCI-3989-cr-methods-error-when-unstarted-alt
branch
from
September 18, 2024 14:16
09a7216
to
5264be4
Compare
ilija42
had a problem deploying
to
integration
September 18, 2024 14:16
— with
GitHub Actions
Failure
jmank88
reviewed
Sep 18, 2024
}, | ||
}, | ||
{ | ||
name: "QueryKey returns sequence data properly", | ||
test: func(t T) { | ||
ctx := tests.Context(t) | ||
cr := tester.GetContractReader(t) | ||
tester.StartServices(ctx, t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably defer closing:
Suggested change
tester.StartServices(ctx, t) | |
tester.StartServices(ctx, t) | |
defer tester.CloseServices(t) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.