Support passing in a values.Value to the chainreader GetLatestValue method #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
reviewed
Sep 18, 2024
ettec
force-pushed
the
chainreader-valuemap-as-arg
branch
from
3da285b
to
7f3d43c
Compare
ilija42
reviewed
Sep 19, 2024
ilija42
reviewed
Sep 19, 2024
ettec
force-pushed
the
chainreader-valuemap-as-arg
branch
2 times, most recently
from
e1b43cb
to
aadd89c
Compare
kidambisrinivas
temporarily deployed
to
integration
GitHub Actions
Inactive
kidambisrinivas
temporarily deployed
to
integration
GitHub Actions
Inactive
kidambisrinivas
had a problem deploying
to
integration
GitHub Actions
Failure
kidambisrinivas
force-pushed
the
chainreader-valuemap-as-arg
branch
from
6234658
to
02f5166
Compare
kidambisrinivas
had a problem deploying
to
integration
GitHub Actions
Failure
kidambisrinivas
temporarily deployed
to
integration
GitHub Actions
Inactive
kidambisrinivas
temporarily deployed
to
integration
GitHub Actions
Inactive
ettec
force-pushed
the
chainreader-valuemap-as-arg
branch
from
a3208c8
to
97591c3
Compare
nolag
approved these changes
Sep 25, 2024
…s GetLatestValue and QueryKey methods
ettec
force-pushed
the
chainreader-valuemap-as-arg
branch
from
8b5bfac
to
731dd13
Compare
kidambisrinivas
approved these changes
Sep 25, 2024
ilija42
reviewed
Sep 25, 2024
cedric-cordenier
added a commit
that referenced
this pull request
Oct 4, 2024
…ethod (#779) * add support for passing in a values.Value type to the contract readers GetLatestValue and QueryKey methods --------- Co-authored-by: Sri Kidambi <[email protected]> Co-authored-by: Cedric Cordenier <[email protected]>
cedric-cordenier
added a commit
that referenced
this pull request
Oct 10, 2024
* [CM-380] Identical Aggregator * [CAPPL-60] Dynamic encoder selection in OCR consensus aggregator * extract encoder name and config * Add more tests * add limit to seq num range (#781) * [chore] Handle aliases in slices (#784) * [chore] Handle aliases in slices * More aliasing tests * Lint fix * Fix test --------- Co-authored-by: Sri Kidambi <[email protected]> * feat(observability-lib): legendoptions + improvement on node general dashboard (#785) * [CAPPL-58] Correctly stub out clock_time_get and poll_oneoff (#778) * [CAPPL-58] Further cleanup * [CAPPL-58] Add support for compression * More alias handling in Unwrap functionality of Value (#792) * Generic case to handle both pointer type and raw type and simplify int unwrap * Handling interface and default * Small test fix --------- Co-authored-by: Cedric Cordenier <[email protected]> * Fix alias typing and tests (#788) * Fix alias typing and tests * Fix ints * errors.new instead of fmt * Add array support to slice (#789) * Replace fmt.Errorf with errors.New where possible (#795) * chore(workflows): adds unit test to utils (#782) * Have the mock runner register with capabilites (#783) * Add binary + config to custom compute (#794) * Add binary + config to custom compute * Add binary + config to custom compute * fix lint issues (#786) * execution factory constructor updated to take two providers, chainIDs, and source token address (#641) * execution factory constructor updated to take two providers and chain IDs (cherry picked from commit 6ad1f08) * Adding source token address to execution factory constructor * Support passing in a values.Value to the chainreader GetLatestValue method (#779) * add support for passing in a values.Value type to the contract readers GetLatestValue and QueryKey methods --------- Co-authored-by: Sri Kidambi <[email protected]> Co-authored-by: Cedric Cordenier <[email protected]> * [CAPPL-31] feat(values): adds support for time.Time as value (#787) * feat(values): adds support for time.Time as value * chore(deps): updates .tool-versions * refactor(values): uses primitive type in protos * feat(values): support float64 values (#799) * confidence level from string (#802) * Float32/Float64 wrapping (#804) * feat: implement sdk logger (#762) * Add MustEmbed Constraint to Contract Reader (#801) Reintroducing the must embed constraint to `ContractReader` implementations to ensure that all implementations of `ContractReader` embed the `UnimplementedContractReader`. If an implementation contains the unemplemented struct, changes to the interface will flow down to all implementations without introducing breaking changes. * Updated TestStruct to enable advanced querying (#798) * Updated TestStruct to enable advanced querying * linting fixes * Update pkg/codec/encodings/type_codec_test.go Co-authored-by: Clement <[email protected]> * Update pkg/codec/encodings/type_codec_test.go Co-authored-by: Clement <[email protected]> * Fixed codec tests --------- Co-authored-by: Clement <[email protected]> * Properly support the range of uint64 and allow big int to unwrap into smaller integer types (#810) * Extract expirable cache abstraction for reuse (#807) * expirable_cache * remove cache (#812) * CCIP-3555 Attestation encoder interfaces (#813) * Attestation encoder interfaces * Attestation encoder interfaces * Attestation encoder interfaces * Comment * [BCF-3392] - ContractReaderByIDs Wrapper (#797) * WIP * Update ContractReaderByIDs interface method names * Unexpose types.ContractReader in contractReaderByIDs * Add multiple contract address support to fakeContractReader for tests * Add GetLatestValue unit test for contractReaderByIDs * Add GetLatestValue unit test for QueryKey * Add BatchGetLatestValues unit test for CR by custom IdDs wrapper * Rm ContractReaderByIDs interface and export the struct * Change ContractReaderByIDs wrapper Unbind handling * Improve ContractReaderByIDs wrapper err handling * Remove mockery usage from ContractReaderByIDs tests * lint * pkg/types/ccipocr3: add DestExecData to RampTokenAmount (#817) * pkg/types/ccipocr3: add DestExecData to RampTokenAmount * fix test * Allow the creation of maps from string to capbility outputs. (#815) * Add the FeeValueJuels field to ccipocr3.Message (#819) * feat(observability-lib): improve alerts rule (#803) * feat(observability-lib): improve alerts rule * chore(observability-lib): README + folder structure (#806) * chore(observability-lib): README + folder structure * feat(observability-lib): variable add current + includeAll options (#808) * chore(README): small corrections * chore(README): example improved * chore(README): add references to dashboards examples * feat(observability-lib): refactor exportable func + link to godoc * fix(observability-lib): cmd errors returns * enable errorf check (#826) * Make overridding the encoder first-class * Update mocks * Mock updates * Adjust tests * Fix mock * Fix mock * Update mock * Linting --------- Co-authored-by: Cedric Cordenier <[email protected]> Co-authored-by: dimitris <[email protected]> Co-authored-by: Sri Kidambi <[email protected]> Co-authored-by: Clement <[email protected]> Co-authored-by: Ryan Tinianov <[email protected]> Co-authored-by: Street <[email protected]> Co-authored-by: Jordan Krage <[email protected]> Co-authored-by: Patrick <[email protected]> Co-authored-by: Matthew Pendrey <[email protected]> Co-authored-by: Gabriel Paradiso <[email protected]> Co-authored-by: Awbrey Hughlett <[email protected]> Co-authored-by: Silas Lenihan <[email protected]> Co-authored-by: Mateusz Sekara <[email protected]> Co-authored-by: ilija42 <[email protected]> Co-authored-by: Makram <[email protected]> Co-authored-by: Ryan Stout <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve-> https://smartcontract-it.atlassian.net/browse/CAPPL-64
Depends on the changes that will form the PR to address: https://smartcontract-it.atlassian.net/browse/CAPPL-63 - changes in pkg/values should be ignored when reviewing this PR. It will not be merge until the PR corresponding to the latter JIRA item is merged.