MultiNode Transaction Sender #879

DylanTinianov · 2024-10-04T17:33:11Z

Description

Ticket: https://smartcontract-it.atlassian.net/browse/BCFR-300

Integrated the use of MultiNode TransactionSender.

Added a sendTx() override to txm which is used to call TransactionSender instead of a single rpc client.
Added Error Classification
Created Loader component to swap out lazy loading with direct calls to MultiNode

Soak Testing: #894

dhaidashenko

Nice work!

pkg/solana/client/multinode/transaction_sender.go

…nk-solana into BCFR-300-multinode-txsender

cl-sonarqube-production · 2024-11-05T14:49:24Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Require wait group for cancel

DylanTinianov and others added 30 commits August 20, 2024 13:55

MultiNode integration setup

60673aa

Merge branch 'develop' into BCI-2835-integrate-multinode

dc85772

Merge branch 'develop' into BCI-2835-integrate-multinode

e6683e6

Update MultiNode files

1c68485

Add MultiNode flag

c44a6ce

Remove internal dependency

64db86a

Fix build

f7c1bc9

Fix import cycle

9e91b47

tidy

354dc50

Update client_test.go

60c3352

Merge branch 'develop' into BCI-2835-integrate-multinode

dcec343

lint

8e2306b

Fix duplicate metrics

b8d6755

Add chain multinode flag

2cb4d77

Extend client

0b33b1f

Implement rpc client methods

3890103

Add defaults

95e1c9a

Add latest block methods

45a7596

Merge branch 'develop' into BCI-2835-integrate-multinode

6641bc9

Address comments

d8d312c

Merge branch 'develop' into BCI-2835-integrate-multinode

aa3c068

lint

3c3756e

Merge branch 'develop' into BCI-2835-integrate-multinode

7c8b55d

Fix lint overflow issues

2521670

Update transaction_sender.go

5b5cfd6

Fix lint

690f812

Validate node config

fd3823b

Update toml.go

4bf96b7

Add SendOnly nodes

c1b83a5

Merge branch 'BCI-2835-integrate-multinode' into BCFR-302-multinode-toml

c58dbc8

DylanTinianov temporarily deployed to integration October 31, 2024 15:14 — with GitHub Actions Inactive

Fix DoAll ctx

85165b6

DylanTinianov temporarily deployed to integration October 31, 2024 15:27 — with GitHub Actions Inactive

DylanTinianov temporarily deployed to integration October 31, 2024 15:32 — with GitHub Actions Inactive

dhaidashenko previously approved these changes Nov 4, 2024

View reviewed changes

pkg/solana/client/multinode/transaction_sender.go Show resolved Hide resolved

jmank88 reviewed Nov 4, 2024

View reviewed changes

pkg/solana/client/multinode/transaction_sender.go Outdated Show resolved Hide resolved

jmank88 previously requested changes Nov 4, 2024

View reviewed changes

pkg/solana/client/multinode/transaction_sender.go Show resolved Hide resolved

jmank88 reviewed Nov 4, 2024

View reviewed changes

pkg/solana/client/multinode/transaction_sender.go Show resolved Hide resolved

defer reportWg

e1e458b

DylanTinianov dismissed dhaidashenko’s stale review via e1e458b November 5, 2024 14:32

Merge branch 'develop' of https://github.com/smartcontractkit/chainli…

e7608b6

…nk-solana into BCFR-300-multinode-txsender

DylanTinianov requested a review from dhaidashenko November 5, 2024 14:35

DylanTinianov temporarily deployed to integration November 5, 2024 14:36 — with GitHub Actions Inactive

DylanTinianov temporarily deployed to integration November 5, 2024 14:37 — with GitHub Actions Inactive

DylanTinianov temporarily deployed to integration November 5, 2024 14:42 — with GitHub Actions Inactive

dhaidashenko approved these changes Nov 5, 2024

View reviewed changes

aalu1418 approved these changes Nov 5, 2024

View reviewed changes

aalu1418 enabled auto-merge (squash) November 5, 2024 16:19

DylanTinianov requested review from jmank88 and removed request for jmank88 November 5, 2024 16:45

aalu1418 merged commit b49b2be into develop Nov 5, 2024
34 of 35 checks passed

aalu1418 deleted the BCFR-300-multinode-txsender branch November 5, 2024 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MultiNode Transaction Sender #879

MultiNode Transaction Sender #879

DylanTinianov commented Oct 4, 2024 •

edited

Loading

dhaidashenko left a comment

cl-sonarqube-production bot commented Nov 5, 2024

MultiNode Transaction Sender #879

MultiNode Transaction Sender #879

Conversation

DylanTinianov commented Oct 4, 2024 • edited Loading

Description

Soak Testing: #894

dhaidashenko left a comment

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Nov 5, 2024

Quality Gate failed

DylanTinianov commented Oct 4, 2024 •

edited

Loading