Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses native go tools to infer git data instead of asking for it on the CLI
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes address the need for aggregating test results with enhanced git and GitHub data, improving the flexibility and accuracy of test report generation. They also cater to the testing framework's ability to handle deeply nested tests and refine the logic for running custom commands, ensuring a more comprehensive and reliable testing process.
What
github.com/smartcontractkit/chainlink-testing-framework/tools/flakeguard/git
.branch-name
flag withcurrent-branch
anddefault-branch
, and addedbase-branch
to capture more detailed git branch information.userGitData
,gitData
,userGitHubData
,gitHubData
) in the aggregation logic, enhancing the report's detail and accuracy.Data
,HubActionsData
) and methods (InferData
,InferGitHubData
) for capturing and processing git and GitHub data.dario.cat/mergo
andgithub.com/rs/zerolog/log
to facilitate merging user-provided data with inferred data and logging.dario.cat/mergo
for merging structs andgithub.com/go-git/go-git/v5
for git operations.TestReport
struct to includeDefaultBranchName
andBaseBranchName
, allowing storage of comprehensive git branch information.TestDeeplyNestedSubTests
to demonstrate handling of deeply nested subtests.t.Parallel()
from certain subtests for clarity and consistency.runCmd
function by directly passing command arguments, enhancing security and performance.