Skip to content

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Oct 22, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes enhance the JD (Job Distributor) component by introducing a new gRPC health check wait strategy and adjusting the workflow configurations for better management of private and public tests. Also, it updates the test setup to reflect these new configurations and ensures the tests run under the correct conditions.

What

  • .github/workflows/framework-golden-tests-private.yml

    • Added a new workflow file for private tests that require access to private container registries.
    • Configured AWS credentials and ECR login steps for accessing private images.
    • Defined a job for running tests that include setting up Go, caching Go modules, and running specific tests based on changes in the framework.
  • .github/workflows/framework-golden-tests.yml

    • Removed the TODO comment about moving sdlc auth to a private workflow, indicating that tests requiring sdlc auth should now use the new private workflow.
  • framework/.changeset/v0.11.3.md

    • Added a changeset file describing enhancements to JD health checks and the addition of a CI test for it.
  • framework/components/jd/grpc_wait_strategy.go

    • Introduced a new file implementing a gRPC health check strategy using Testcontainers-go, providing a structured way to wait for a gRPC service to be healthy before proceeding with tests.
  • framework/components/jd/jd.go

    • Modified the JD component to support the new gRPC health check strategy.
    • Added checks and configurations related to the health check and WSRPC health port to ensure proper service initialization and testing.
  • framework/examples/myproject/jd_test.go

    • Renamed and moved jd_test.go to reflect its purpose more accurately and adjusted the test to utilize environment variables and configurations relevant to private testing scenarios.
  • framework/examples/myproject_cll/go.mod & framework/examples/myproject_cll/go.sum

    • Updated module and sum files to reflect new and updated dependencies, ensuring compatibility and the latest features are used.
  • framework/go.mod & framework/go.sum

    • Updated the framework's module and sum files to align with changes in dependencies, including the grpc package update, ensuring the framework uses compatible versions across all components.

@Tofel Tofel force-pushed the jd-better-health-check branch from b3ff450 to 7ef6f0b Compare October 22, 2025 14:55
@Tofel Tofel marked this pull request as ready for review October 22, 2025 18:00
@Tofel Tofel requested a review from a team as a code owner October 22, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant