Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/keystone beholder integration #14510

Merged
merged 24 commits into from
Oct 17, 2024
Merged

Feature/keystone beholder integration #14510

merged 24 commits into from
Oct 17, 2024

Conversation

patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Sep 20, 2024 •
edited
Loading

Initial integration of Keystone w/ beholder

Dependencies

https://github.com/smartcontractkit/chainlink-common/pull/828/commits

patrickhuie19
patrickhuie19 commented Sep 20, 2024
View reviewed changes
core/logger/logger.go Outdated Show resolved Hide resolved
@patrickhuie19 patrickhuie19 changed the title Feature/keystone beholder alerts Feature/keystone beholder integration Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

vyzaldysanchez
vyzaldysanchez previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@vyzaldysanchez vyzaldysanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kalverra
kalverra previously approved these changes Oct 16, 2024
View reviewed changes
@patrickhuie19 patrickhuie19 added this pull request to the merge queue Oct 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2024
@patrickhuie19
Feature/keystone beholder integration (#14510)
1357723 
* added TODO placeholders

* sketch of adding beholder custom messages

* other options

* adding more idiomatic option

* unit testing labeling

* adding a sample beholder metric emission

* refactoring to use labeled context utilities

* bumping common to use custom proto for Keystone Custom Message

* trying out sendLogAsCustomMessageWithLabels

* simplifying

* bumping chainlink-common

* adding labels field to Engine + expanding log as custom message API in workflow monitoring

* gomodtidy

* Adding customMessageAgent

* adding initial engine metrics

* minor cleanup

* %s --> %w. interface{} --> any

* Feature/keystone beholder alerts syncer 2 (#14786)

* manually adding edits from closed PR #14744

* cleanup

* lint

* lint

* adding newline back to .tool-versions
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
vyzaldysanchez
vyzaldysanchez previously approved these changes Oct 16, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
5 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
74.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@patrickhuie19 patrickhuie19 added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@patrickhuie19 patrickhuie19 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit dd59dc9 Oct 17, 2024
127 of 128 checks passed
@patrickhuie19 patrickhuie19 deleted the feature/keystone-beholder-alerts branch October 17, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier left review comments

@krehermann krehermann krehermann approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny EasterTheBunny is a code owner automatically assigned from smartcontractkit/foundations

@kalverra kalverra Awaiting requested review from kalverra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrickhuie19 @vyzaldysanchez @kalverra @krehermann @cedric-cordenier