-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial helpers for RMN in crib #16258
base: develop
Are you sure you want to change the base?
Conversation
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Core Tests (go_core_ccip_deployment_tests) , test-scripts , lint , SonarQube Scan 1. Linting issues found in code: Golang Lint (deployment)Source of Error:
Why: The errors are due to code style issues detected by the Suggested fix: Refactor the code to use named results for clarity and follow proper variable naming conventions (e.g., use AER Report: Operator UI CI ran successfully ✅ |
|
||
allChains := e.AllChainSelectors() | ||
rmnRemoteConfig := make(map[uint64]changeset.RMNRemoteConfig) | ||
for _, chain := range allChains { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than creating a single changeset to apply all chains, we should create a changeset per chain
This should improve the deployment speed when running load tests on 30+chains
deployment/environment/devenv/rmn.go
Outdated
// Copy the file from container | ||
reader, err := container.CopyFileFromContainer(context.Background(), "/app/"+RMNKeyStore) | ||
if err != nil { | ||
log.Fatalf("Failed to copy file: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than this CI error and the comment above, lgtm
…crib-helpers-for-rmn
…crib-helpers-for-rmn
…ainlink into crib-helpers-for-rmn
…crib-helpers-for-rmn
|
This PR is done in the scope of chaos and load test for CCIP 1.6.
It adds utilities to create RMN nodes keystores and group all necessary changeset to make active on a CCIP environment
How to use
Example assuming 3 nodes
rmnNodes will contain the rawKeystore file for both rageproxy and afn2proxy that you can reuse when spinning up the containers in crib
SetupRMNNodeOnAllChains
Note: Later on in crib you will also need a shared.toml for the afn2proxy, this file can be generated automatically by using this command or at least replicate the logic in there