Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRE-332] Standalone Workflow Engine script #16579

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Feb 26, 2025

No description provided.

@bolekk bolekk force-pushed the feature/CRE-332-standalone-engine branch from 5b33018 to 2b7f9e6 Compare March 10, 2025 23:16
Copy link
Contributor

github-actions bot commented Mar 10, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , GolangCI Lint (system-tests/lib) , GolangCI Lint (core/scripts) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (.) , GolangCI Lint (integration-tests/load) , GolangCI Lint (system-tests/tests) , GolangCI Lint (integration-tests) , test-scripts , GolangCI Lint (deployment) , lint , SonarQube Scan

1. GolangCI Lint job failed due to integer overflow conversion issues: lint

Source of Error:
Golang Lint (.)	2025-03-11T21:50:09.6143104Z ##[error]core/capabilities/fakes/streams_trigger.go:187:47: G115: integer overflow conversion uint64 -> int64 (gosec)
Golang Lint (.)	2025-03-11T21:50:09.6144512Z 		if reg.cfg.MaxFrequencyMs > 0 && newTs%int64(reg.cfg.MaxFrequencyMs) != 0 {
Golang Lint (.)	2025-03-11T21:50:09.6145450Z 		 ^
Golang Lint (.)	2025-03-11T21:50:09.6147328Z ##[error]core/capabilities/fakes/streams_trigger.go:211:29: G115: integer overflow conversion int64 -> uint32 (gosec)
Golang Lint (.)	2025-03-11T21:50:09.6148153Z 		Timestamp: uint32(timestamp),
Golang Lint (.)	2025-03-11T21:50:09.6148689Z 		 ^
Golang Lint (.)	2025-03-11T21:50:09.6149764Z ##[error]core/capabilities/fakes/streams_trigger.go:212:29: G115: integer overflow conversion int64 -> uint32 (gosec)
Golang Lint (.)	2025-03-11T21:50:09.6150639Z 		ValidFromTimestamp: uint32(timestamp),
Golang Lint (.)	2025-03-11T21:50:09.6151190Z 		 ^
Golang Lint (.)	2025-03-11T21:50:09.6152223Z ##[error]core/capabilities/fakes/streams_trigger.go:217:29: G115: integer overflow conversion int64 -> uint32 (gosec)
Golang Lint (.)	2025-03-11T21:50:09.6153059Z 		ExpiresAt: uint32(timestamp + 1000000),
Golang Lint (.)	2025-03-11T21:50:09.6153636Z 		 ^

Why: The GolangCI Lint job failed due to multiple instances of potential integer overflow conversions in the streams_trigger.go file. These conversions can lead to incorrect values or runtime errors if the values exceed the target type's limits.

Suggested fix: Review and correct the type conversions in the streams_trigger.go file to ensure they are safe. Use appropriate checks or type-safe methods to handle potential overflows. For example, ensure that the values being converted fit within the range of the target type before performing the conversion.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@bolekk bolekk force-pushed the feature/CRE-332-standalone-engine branch from 2b7f9e6 to fbe3b47 Compare March 11, 2025 00:23
@bolekk bolekk force-pushed the feature/CRE-332-standalone-engine branch 2 times, most recently from e47fb3e to 6b8fb58 Compare March 11, 2025 16:28
jinhoonbang
jinhoonbang previously approved these changes Mar 11, 2025
@bolekk bolekk force-pushed the feature/CRE-332-standalone-engine branch from 6b8fb58 to a51ca5a Compare March 11, 2025 21:23
@bolekk bolekk marked this pull request as ready for review March 11, 2025 21:23
@bolekk bolekk requested review from a team as code owners March 11, 2025 21:23
@bolekk bolekk force-pushed the feature/CRE-332-standalone-engine branch from a51ca5a to f52d353 Compare March 11, 2025 21:45
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants