Cappl 588/rate limit per workflow #16672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (.) , test-scripts , lint , SonarQube Scan 1. GolangCI Lint errors:[lint]Source of Error:Why: The errors are caused by violations of Go naming conventions and improper usage of Go syntax. Specifically, the use of underscores in variable names, improper variable naming, and incorrect usage of the Suggested fix: Rename the variables to follow Go naming conventions (e.g., AER Report: Operator UI CI ran successfully ✅ |
MStreet3
force-pushed
the
cappl-588/rate-limit-per-workflow-id
branch
from
ad6dcae to
059bb26
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
justinkaseman
force-pushed
the
cappl-588/rate-limit-per-workflow-id
branch
from
ce9c1de to
9925ad8
Compare
| @@ -836,7 +836,7 @@ func (e *Engine) workerForStepRequest(ctx context.Context, msg stepRequest) { | |||
|
|
|||
| var stepStatus string | |||
| switch { | |||
| case errors.Is(capabilities.ErrStopExecution, err): | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you say more about why this change was necessary?
There was a problem hiding this comment.
Tagging @MStreet3 , because he made the original change, I just fixed it to work from what he had.
I'm guessing that he noticed that the usage was wrong, which flipped it from
// Not intended usage, see errors.Is doc
case errors.Is(capabilities.ErrStopExecution, err):
// Intended usage
case errors.Is(err, capabilities.ErrStopExecution):
Moving it to case errors.Is(err, capabilities.ErrStopExecution): caused tests to fail, so I changed it to what it is now.
| if !c.rateLimiter.Allow(body.Sender) { | ||
| // error is logged here instead of warning because if a message from gateway is rate-limited, | ||
| // the workflow will eventually fail with timeout as there are no retries in place yet | ||
| c.lggr.Errorw("request rate-limited") | ||
| l.Errorw("request rate-limited") | ||
| return |
There was a problem hiding this comment.
Technically out of scope, but could we return an error here back to the caller? I think this results in nicer UX by telling users they were rate limited rather than returning a timeout.
There was a problem hiding this comment.
…GatewayMessage on rate limit
|
| @@ -36,7 +37,13 @@ const ( | |||
|
|
|||
| var defaultConfig = Config{ | |||
| ServiceConfig: webapi.ServiceConfig{ | |||
| RateLimiter: common.RateLimiterConfig{ | |||
There was a problem hiding this comment.
This is a breaking API change I think 🤔 ?
| PerWorkflowRPS: 100.0, | ||
| PerWorkflowBurst: 100, | ||
| }, | ||
| IncomingRateLimiter: gwcommon.RateLimiterConfig{ |
There was a problem hiding this comment.
IMO not worth having an extra struct + a duplicated implementation -- can we somehow either reuse gwcommon.RateLimiterConfig but with a different struct and constructor for config?
eg.
type OutgoingRateLimiter struct {
...
PerWorkflowRPS
PerWorkflowBurst
}
func NewOutgoingRateLimiter(rl ...) gwcommon.RateLimiter {
return gwcommon.RateLimiter{
... convert between the two types
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports