Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat:CRE-86): Forwarder view - revisited #16674

Draft
wants to merge 13 commits into
base: task/CRE-338/keystone-forwarder-deployment-lbls
Choose a base branch
from

Conversation

vyzaldysanchez
Copy link
Contributor

@vyzaldysanchez vyzaldysanchez commented Mar 5, 2025

This restores the changes reverted on #16637 addressing the following stories:

It adds the following improvements to the Forwarder View generation:

  • Using labels from forwarder addresses to find the deployment block and fetch SetConfig events from there.
  • Using the already existing views, to check if the forwarder data exists and use the latest SetConfig block number to fetch events that happen afterwards, to improve performance and reduce execution time.
  • Add parallelism to the view generation, and allow the view to be generated even if the context is cancelled for the forwarder view, so we abandon the forwarder view generation altogether in that case.

Requires

Supports

Copy link
Contributor

github-actions bot commented Mar 5, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Flakeguard Summary

Ran new or updated tests between task/CRE-338/keystone-forwarder-deployment-lbls and 6c91b2b (task/CRE-86/restore-forwarder-view).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

2 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestKeystoneView 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/keystone/changeset false 2.326666666s @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation
TestKeystoneView/fails_to_generate_a_view_of_the_keystone_state_with_OCR3_not_configured 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/keystone/changeset false 163.333333ms @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-a7970666-611d-44d9-900c-ef1e143fe20e.json.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Flakeguard Summary

Ran new or updated tests between task/CRE-338/keystone-forwarder-deployment-lbls and a1e366d (task/CRE-86/restore-forwarder-view).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

2 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestKeystoneView 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/keystone/changeset false 2.493333333s @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation
TestKeystoneView/fails_to_generate_a_view_of_the_keystone_state_with_OCR3_not_configured 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/keystone/changeset false 176.666666ms @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-25083f7d-8ac9-4859-8734-99c168af4e3e.json.

@@ -113,4 +113,4 @@ type ChangesetOutput struct {

// ViewState produces a product specific JSON representation of
// the on and offchain state of the environment.
type ViewState func(e Environment) (json.Marshaler, error)
type ViewState func(e Environment, previousState []byte) (json.Marshaler, error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this backward compatibility, ie add a ViewStateV2
and make the []byte into json.Marshaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants