-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat:CRE-86): Forwarder view - revisited #16674
base: task/CRE-338/keystone-forwarder-deployment-lbls
Are you sure you want to change the base?
(feat:CRE-86): Forwarder view - revisited #16674
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌2 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-a7970666-611d-44d9-900c-ef1e143fe20e.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌2 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs-25083f7d-8ac9-4859-8734-99c168af4e3e.json. |
deployment/changeset.go
Outdated
@@ -113,4 +113,4 @@ type ChangesetOutput struct { | |||
|
|||
// ViewState produces a product specific JSON representation of | |||
// the on and offchain state of the environment. | |||
type ViewState func(e Environment) (json.Marshaler, error) | |||
type ViewState func(e Environment, previousState []byte) (json.Marshaler, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this backward compatibility, ie add a ViewStateV2
and make the []byte into json.Marshaller
|
This restores the changes reverted on #16637 addressing the following stories:
It adds the following improvements to the Forwarder View generation:
SetConfig
events from there.SetConfig
block number to fetch events that happen afterwards, to improve performance and reduce execution time.Requires
Supports