Move context cancellation of register trigger in cleanup loop #16675
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
|
jmank88
approved these changes
Mar 6, 2025
| @@ -162,16 +163,17 @@ func (p *triggerPublisher) Receive(_ context.Context, msg *types.MessageBody) { | |||
| } | |||
| ctx, cancel := p.stopCh.NewCtx() | |||
| callbackCh, err := p.underlying.RegisterTrigger(ctx, unmarshaled) | |||
| cancel() | |||
| if err == nil { | |||
There was a problem hiding this comment.
nit/ Why do we handle the success case first? Same with the surrounding block. Usually the linter suggests error handling first, with a return, so that the subsequent logic can be inline instead of an indented block. Typically makes things much easier to read.
bolekk
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a context management issue where premature context cancellation could close a gRPC streaming server (
triggerExecutableClient) after trigger registration.