Remove automation 1_2, 1_3 and 2_0 code. #16677

pavel-raykov · 2025-03-05T20:10:05Z

No description provided.

github-actions · 2025-03-05T20:10:50Z

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

github-actions · 2025-03-05T20:31:31Z

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (core/scripts) , GolangCI Lint (.) , GolangCI Lint (integration-tests) , lint , SonarQube Scan

1. GolangCI Lint errors in `integration-tests` job:integration-tests

Source of Error:

contracts/ethereum_contracts_automation.go:802:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:818:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:823:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:826:9: cannot use &EthereumKeeperRegistry{…} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:842:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:852:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:857:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:863:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:868:10: cannot use &EthereumKeeperRegistry{} (value of type *EthereumKeeperRegistry) as KeeperRegistry value in return statement: *EthereumKeeperRegistry does not implement KeeperRegistry (missing method Migrate)
contracts/ethereum_contracts_automation.go:1340:15: undefined: keeper_registrar_wrapper1_2
contracts/ethereum_contracts_automation.go:868:10: too many errors (typecheck)

Why: The EthereumKeeperRegistry struct does not implement the KeeperRegistry interface because it is missing the Migrate method. Additionally, there is an undefined reference to keeper_registrar_wrapper1_2.

Suggested fix: Implement the Migrate method in the EthereumKeeperRegistry struct and ensure that keeper_registrar_wrapper1_2 is defined or imported correctly.

2. GolangCI Lint error in `core/scripts` job:core/scripts

Source of Error:

core/scripts/chaincli/handler/keeper.go:15:1: File is not properly formatted (goimports)
	registry20 "github.com/smartcontractkit/chainlink/v2/core/gethwrappers/generated/keeper_registry_wrapper2_0"
^

Why: The file keeper.go is not properly formatted according to goimports.

Suggested fix: Run goimports on the file to ensure it is properly formatted.

3. Test failure in `go_core_tests` job:go_core_tests

Source of Error:

--- FAIL: TestKeeperForwarderEthIntegration (0.05s)
--- FAIL: TestKeeperForwarderEthIntegration/keeper_forwarder_flow (0.05s)
panic: Deployment of registry verdion 3 not defined [recovered]
	panic: Deployment of registry verdion 3 not defined

goroutine 1138 [running]:
testing.tRunner.func1.2({0x60fde00, 0xc0043faee8})
	/opt/hostedtoolcache/go/1.24.0/x64/src/testing/testing.go:1734 +0x21c
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.24.0/x64/src/testing/testing.go:1737 +0x35e
panic({0x60fde00?, 0xc0043faee8?})
	/opt/hostedtoolcache/go/1.24.0/x64/src/runtime/panic.go:787 +0x132
github.com/smartcontractkit/chainlink/v2/core/services/keeper_test.deployKeeperRegistry(0x0?, 0x0?, 0xc000593a10?, 0x1?, {0xc4, 0x13, 0x54, 0xf1, 0x88, 0x23, ...}, ...)
	/home/runner/work/chainlink/chainlink/core/services/keeper/integration_test.go:77 +0x3ce
github.com/smartcontractkit/chainlink/v2/core/services/keeper_test.TestKeeperForwarderEthIntegration.func1(0xc000dea000)
	/home/runner/work/chainlink/chainlink/core/services/keeper/integration_test.go:307 +0xac5
testing.tRunner(0xc000dea000, 0x728e5e8)
	/opt/hostedtoolcache/go/1.24.0/x64/src/testing/testing.go:1792 +0xf4
created by testing.(*T).Run in goroutine 363
	/opt/hostedtoolcache/go/1.24.0/x64/src/testing/testing.go:1851 +0x413

Why: The test TestKeeperForwarderEthIntegration fails because the deployment of registry version 3 is not defined.

Suggested fix: Define the deployment for registry version 3 in the test setup or modify the test to use an existing defined deployment.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

github-actions · 2025-03-05T20:38:26Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

github-actions · 2025-03-10T17:56:34Z

Flakeguard Summary

Ran new or updated tests between develop and 65595d8 (ref-automation).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

2 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestKeeperForwarderEthIntegration/keeper_forwarder_flow	0%	false	false	false	1	0	1	0	github.com/smartcontractkit/chainlink/v2/core/services/keeper	true	130ms	@smartcontractkit/dev-services
TestUpkeepIdentifer_String/small	75%	true	true	false	3	3	3	0	github.com/smartcontractkit/chainlink/v2/core/services/keeper	true	0s	@smartcontractkit/dev-services

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions · 2025-03-10T18:28:53Z

Flakeguard Summary

Ran new or updated tests between develop and 4d8d2a8 (ref-automation).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

2 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestMaxPerformDataSize/max_perform_data_size_test	0%	false	false	false	1	0	1	0	github.com/smartcontractkit/chainlink/v2/core/services/keeper	true	140ms	@smartcontractkit/dev-services
TestUpkeepIdentifer_String/small	75%	true	true	false	3	3	3	0	github.com/smartcontractkit/chainlink/v2/core/services/keeper	true	0s	@smartcontractkit/dev-services

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions · 2025-03-10T19:03:50Z

Flakeguard Summary

Ran new or updated tests between develop and 84f1ddf (ref-automation).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

2 Results

Name	Pass Ratio	Panicked?	Timed Out?	Race?	Runs	Successes	Failures	Skips	Package	Package Panicked?	Avg Duration	Code Owners
TestKeeperForwarderEthIntegration/keeper_forwarder_flow	0%	false	false	false	1	0	1	0	github.com/smartcontractkit/chainlink/v2/core/services/keeper	true	160ms	@smartcontractkit/dev-services
TestUpkeepIdentifer_String/small	75%	true	true	false	3	3	3	0	github.com/smartcontractkit/chainlink/v2/core/services/keeper	true	0s	@smartcontractkit/dev-services

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

cl-sonarqube-production · 2025-03-10T19:05:56Z

Quality Gate passed

Issues
0 New issues
35 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Minor

f461d91

Minor

8e32bb5

pavel-raykov changed the title ~~Remove automation 1_2 code.~~ Remove automation 1_2, 1_3 and 2_0 code. Mar 5, 2025

Minor

4fc8fc2

pavel-raykov added 2 commits March 6, 2025 15:28

Minor

5fbcab3

Minor

65595d8

pavel-raykov added 2 commits March 10, 2025 19:13

Minor

fce02b8

Minor

4d8d2a8

Minor

84f1ddf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove automation 1_2, 1_3 and 2_0 code. #16677

Remove automation 1_2, 1_3 and 2_0 code. #16677

pavel-raykov commented Mar 5, 2025

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 10, 2025

github-actions bot commented Mar 10, 2025

github-actions bot commented Mar 10, 2025

cl-sonarqube-production bot commented Mar 10, 2025

Remove automation 1_2, 1_3 and 2_0 code. #16677

Are you sure you want to change the base?

Remove automation 1_2, 1_3 and 2_0 code. #16677

Conversation

pavel-raykov commented Mar 5, 2025

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 5, 2025 • edited Loading

AER Report: CI Core

1. GolangCI Lint errors in integration-tests job:integration-tests

2. GolangCI Lint error in core/scripts job:core/scripts

3. Test failure in go_core_tests job:go_core_tests

AER Report: Operator UI CI ran successfully ✅

github-actions bot commented Mar 5, 2025

github-actions bot commented Mar 10, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

github-actions bot commented Mar 10, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

github-actions bot commented Mar 10, 2025

Flakeguard Summary

Found Flaky Tests ❌

Artifacts

cl-sonarqube-production bot commented Mar 10, 2025

Quality Gate passed

github-actions bot commented Mar 5, 2025 •

edited

Loading

1. GolangCI Lint errors in `integration-tests` job:integration-tests

2. GolangCI Lint error in `core/scripts` job:core/scripts

3. Test failure in `go_core_tests` job:go_core_tests