[CCIP-5118] Refactor Test_CCIPMessageLimitations logic into helper pkg #16680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
makramkd
reviewed
Mar 10, 2025
Comment on lines
+62
to
+66
| type TestCaseOutput struct { | ||
| MsgSentEvent *onramp.OnRampCCIPMessageSent | ||
| } | ||
|
|
||
| func Run(tc TestCase) TestCaseOutput { |
There was a problem hiding this comment.
LGTM, can we use this helper struct + method in the current message limitations test as well?
There was a problem hiding this comment.
Yes, this is the one item I have left in the TODOs.
|
NourElRashidy
requested review from
winder,
asoliman92,
matYang,
makramkd,
dimkouv,
0xAustinWang and
0xnogo
AnieeG
approved these changes
Mar 11, 2025
| } | ||
|
|
||
| // Use this when testhelpers.DeployedEnv is not available (usually in long-running test environments like staging). | ||
| func NewTestSetup( |
There was a problem hiding this comment.
nit: how about using functional opts here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCIP-5118
Supports
TODO