Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable solana LOOPP mode by default #16685

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Mar 6, 2025

This PR enables the Solana LOOP plugin by default. It can still be disabled by unsetting the env var. In a future release, embedded mode will be removed, leaving LOOP mode as the only option.

TODO:

  • Do other dockerfiles/goreleaser files need to be updated?

augustbleeds
augustbleeds previously approved these changes Mar 6, 2025
Copy link
Contributor

@augustbleeds augustbleeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadepark-dev so starting from now, we'll enable LOOP by default

action items: once that release is ready for QA, we need to update our internal clusters.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

jadepark-dev
jadepark-dev previously approved these changes Mar 6, 2025
@jmank88 jmank88 requested a review from Bwest981 March 11, 2025 23:54
@jmank88
Copy link
Contributor Author

jmank88 commented Mar 11, 2025

@chainchad Are there any other dockerfiles or goreleaser files to update?

@jmank88 jmank88 dismissed stale reviews from jadepark-dev and augustbleeds via c8b2f7f March 12, 2025 01:14
@jmank88 jmank88 force-pushed the solana-loopp-default-enabled branch from 683ddda to c8b2f7f Compare March 12, 2025 01:14
@jmank88 jmank88 marked this pull request as ready for review March 12, 2025 01:14
@jmank88 jmank88 requested review from a team as code owners March 12, 2025 01:14
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@jmank88 jmank88 enabled auto-merge March 12, 2025 01:14
@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants