Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPPL-620] configure MaxResponseSizeBytes on jobspec #16693

Merged
merged 2 commits into from
Mar 11, 2025
Merged

[CAPPL-620] configure MaxResponseSizeBytes on jobspec #16693

merged 2 commits into from
Mar 11, 2025

Conversation

agparadiso
Copy link
Contributor

@agparadiso agparadiso commented Mar 7, 2025 •
edited
Loading

Description

This pr allows the configuration of the MaxResponseSizeBytes via the jobspec
CAPPL-620

Requires

Supports

cedric-cordenier
cedric-cordenier reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@cedric-cordenier cedric-cordenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but please add a test 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@agparadiso agparadiso force-pushed the CAPPL-620_allow_MaxFetchResponseSizeBytes_configuration_via_jobspec branch from 1435815 to 517bd43 Compare March 10, 2025 15:47
@agparadiso agparadiso force-pushed the CAPPL-620_allow_MaxFetchResponseSizeBytes_configuration_via_jobspec branch from 517bd43 to c8c0cff Compare March 10, 2025 16:16
@agparadiso agparadiso marked this pull request as ready for review March 10, 2025 18:07
@agparadiso agparadiso requested review from a team as code owners March 10, 2025 18:07
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@agparadiso agparadiso enabled auto-merge March 10, 2025 18:39
@agparadiso agparadiso changed the title [CAPPL-620] configure MaxFetchResponseSizeBytes on jobspec [CAPPL-620] configure MaxResponseSizeBytes on jobspec Mar 11, 2025
@agparadiso agparadiso added this pull request to the merge queue Mar 11, 2025
Merged via the queue into develop with commit ff41c97 Mar 11, 2025
190 of 191 checks passed
@agparadiso agparadiso deleted the CAPPL-620_allow_MaxFetchResponseSizeBytes_configuration_via_jobspec branch March 11, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@justinkaseman justinkaseman justinkaseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agparadiso @cedric-cordenier @justinkaseman