Add changeset that adds a new chain to CCIP 1.6.0 (E2E) #16705
Conversation
kylesmartin
requested review from
winder,
asoliman92,
matYang,
makramkd,
dimkouv,
mateusz-sekara and
b-gopalswami
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , test-scripts , Core Tests (go_core_race_tests) , Core Tests (go_core_ccip_deployment_tests) , lint , SonarQube Scan 1. Error return value not checked: Golang Lint (deployment)Source of Error:Why: The error occurs because the return value of the Suggested fix: Check the return value of the if err := newAddresses.Merge(output.AddressBook); err != nil {
// handle the error
}2. Lint job failed: Check Golangci-lint Matrix ResultsSource of Error:Why: This error indicates that at least one of the GolangCI Lint matrix jobs failed, which is likely due to the unchecked error return value mentioned above. Suggested fix: Fix the specific linting issue(s) identified in the logs (e.g., checking the return value of AER Report: Operator UI CI ran successfully ✅ |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
|
| - SetCandidateChangeset | ||
| - PromoteCandidateChangeset | ||
|
|
||
| 3. Run changesets against all requested source chains (including home chain if required) WITH MCMS |
There was a problem hiding this comment.
if TestRouter is true, you won't need MCMS here, Test Router is deployed through DeployChainContractsChangeset and it will still be owned by deployer key
| - SetCandidateChangeset | ||
| - PromoteCandidateChangeset |
There was a problem hiding this comment.
I am not sure how safe it would be to merge SetCandidate and Promote Candidate. Can we have two changesets for this piece?
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
| - UpdateFeeQuoterDestsChangeset | ||
| - UpdateOffRampSourcesChangeset (TestRouter = true) | ||
| - UpdateOnRampsDestsChangeset (TestRouter = true) | ||
| - UpdateRouterRampsChangeset (for both inbound and outbound traffic, TestRouter = true) |
There was a problem hiding this comment.
There is also deployMCMs contracts, saveExistingTokenAddresses, saveFeedAddreses
| 1. Run changesets against new chain WITHOUT MCMS | ||
| - DeployPrerequisitesChangeset | ||
| - DeployChainContractsChangeset | ||
| - SetOCR3OffRampChangeset |
There was a problem hiding this comment.
This needs MCMS. The Pre-condition is transferring ownership of offRamp to timelock
There was a problem hiding this comment.
This shouldn't be required, we discuss @ sync today
https://smartcontract-it.atlassian.net/browse/CCIP-5398