Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCR2 spec_is and plugin_id write config logging #16707

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Add OCR2 spec_is and plugin_id write config logging #16707

wants to merge 2 commits into from

Conversation

cawthorne
Copy link
Contributor

@cawthorne cawthorne commented Mar 10, 2025 •
edited
Loading

Just trying to add a log to help debug an issue

@cawthorne cawthorne requested review from a team as code owners March 10, 2025 16:33
@cawthorne cawthorne requested a review from pavel-raykov March 10, 2025 16:33
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cawthorne cawthorne added build-publish Build and Publish image to SDLC and removed build-publish Build and Publish image to SDLC labels Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cawthorne cawthorne added the build-publish Build and Publish image to SDLC label Mar 10, 2025
pavel-raykov
pavel-raykov reviewed Mar 10, 2025
View reviewed changes
core/services/ocr2/database.go Outdated
@@ -190,6 +190,9 @@ func (d *db) WriteConfig(ctx context.Context, c ocrtypes.ContractConfig) error {
offchain_config = EXCLUDED.offchain_config,
updated_at = NOW()
`

d.lggr.Info("Writing OCR2 config", "ocr2_oracle_spec_id", d.oracleSpecID, "ocr2_plugin_id", d.pluginID)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it is not really clear why you need this.

Furthermore, did you want to use Infow and not plain Info?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just doing some debugging for an issue I am facing, no plans to merge this in at the moment.

I would like to be able to set this image to be used for the DON I am testing on in infra-k8s.

@cawthorne cawthorne marked this pull request as draft March 10, 2025 17:01
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-raykov pavel-raykov pavel-raykov left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
build-publish Build and Publish image to SDLC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cawthorne @pavel-raykov