Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana ccip verified builds #16711

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

solana ccip verified builds #16711

wants to merge 2 commits into from

Conversation

tt-cll
Copy link
Contributor

@tt-cll tt-cll commented Mar 10, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Mar 10, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Scheduled Run Frequency , Detect Changes , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (deployment) , test-scripts , lint , SonarQube Scan

1. Linting error in cs_build_solana.go file: [Golang Lint (deployment)]

Source of Error:
Golang Lint (deployment)	2025-03-10T20:03:05.7754334Z ##[error]deployment/ccip/changeset/solana/cs_build_solana.go:151:9: elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
Golang Lint (deployment)	2025-03-10T20:03:05.7755464Z 	} else {
Golang Lint (deployment)	2025-03-10T20:03:05.7755786Z 	 ^

Why: The linter detected an unnecessary else block that can be simplified by using else if directly, improving code readability and maintainability.

Suggested fix: Replace the else { if cond {}} structure with else if cond {}.

2. Linting error in cs_build_solana.go file: [Golang Lint (deployment)]

Source of Error:
Golang Lint (deployment)	2025-03-10T20:03:05.7757680Z ##[error]deployment/ccip/changeset/solana/cs_build_solana.go:336:19: fmt.Sprintf can be replaced with string concatenation (perfsprint)
Golang Lint (deployment)	2025-03-10T20:03:05.7758719Z 		e.Logger.Debugw(fmt.Sprintf("Verifying %s", v.name))
Golang Lint (deployment)	2025-03-10T20:03:05.7759257Z 		 ^

Why: The linter suggests that using fmt.Sprintf for simple string concatenation is less efficient than using the + operator directly.

Suggested fix: Replace fmt.Sprintf("Verifying %s", v.name) with "Verifying " + v.name.

3. Linting issues found: [Golang Lint (deployment)]

Source of Error:
Golang Lint (deployment)	2025-03-10T20:03:05.7772470Z ##[error]issues found
Golang Lint (deployment)	2025-03-10T20:03:05.7772944Z Ran golangci-lint in 118825ms

Why: The GolangCI Lint job found issues in the code that need to be addressed.

Suggested fix: Review the detailed linting report and fix the identified issues in the code.

4. GolangCI Lint matrix job failed: [Check Golangci-lint Matrix Results]

Source of Error:
Check Golangci-lint Matrix Results	2025-03-10T20:03:17.4486927Z At least one 'GolangCI Lint' matrix job failed. Check the failed lint jobs.
Check Golangci-lint Matrix Results	2025-03-10T20:03:17.4511637Z ##[error]Process completed with exit code 1.

Why: The overall GitHub Action run failed because at least one GolangCI Lint job did not pass due to the linting errors found.

Suggested fix: Address the specific linting errors mentioned above and re-run the GitHub Action to ensure all linting checks pass.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant