Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement report telemetry for LLO #16712

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Implement report telemetry for LLO #16712

wants to merge 2 commits into from

Conversation

samsondav
Copy link
Collaborator

Requires

Supports

@samsondav samsondav force-pushed the MERC-6875 branch 5 times, most recently from b654ecd to 46bf77b Compare March 11, 2025 12:35
@samsondav samsondav marked this pull request as ready for review March 11, 2025 12:35
@samsondav samsondav requested review from a team as code owners March 11, 2025 12:35
@samsondav samsondav requested a review from jmank88 March 11, 2025 12:35
@github-actions GitHub Actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and b654ecd (MERC-6875).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_Telemeter_reportTelemetry 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/llo false 0s @smartcontractkit/data-streams-engineers, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@github-actions GitHub Actions
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 15d543b (MERC-6875).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
Test_Telemeter_reportTelemetry 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/llo false 0s @smartcontractkit/data-streams-engineers, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@samsondav samsondav force-pushed the MERC-6875 branch 2 times, most recently from f2571b7 to ab72348 Compare March 11, 2025 13:25
@samsondav samsondav requested a review from jmank88 March 11, 2025 13:40
@samsondav samsondav enabled auto-merge March 11, 2025 13:41
jmank88
jmank88 previously approved these changes Mar 11, 2025
View reviewed changes
@samsondav samsondav requested a review from jmank88 March 11, 2025 13:48
@samsondav samsondav added the build-publish Build and Publish image to SDLC label Mar 11, 2025
@samsondav samsondav requested a review from a team as a code owner March 11, 2025 19:32
samsondav
samsondav commented Mar 11, 2025
View reviewed changes
core/services/llo/delegate.go
Logger: lggr,
MonitoringEndpoint: cfg.PluginMonitoringEndpoint,
DonID: cfg.DonID,
CaptureObservationTelemetry: cfg.CaptureEATelemetry, // a bit awkwardly named for backwards compatibility but ObservationTelemetry covers both EA and Observation telemetry
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: can we split this ?

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 Awaiting requested review from jmank88

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
build-publish Build and Publish image to SDLC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsondav @jmank88