feat: ds configurator Changesets #16713
Open
+1,406
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
ChrisAmora
force-pushed
the
feat/configurator
branch
from
a8de9e4 to
9eb250b
Compare
ChrisAmora
requested review from
winder,
asoliman92,
matYang,
makramkd,
dimkouv,
0xAustinWang and
0xnogo
ChrisAmora
changed the title
akuzni2
reviewed
Mar 11, 2025
akuzni2
reviewed
Mar 11, 2025
akuzni2
reviewed
Mar 11, 2025
|
Since we currently have 6 contract types - does it make sense to organize them into their own package? I think this organization would make sense when we start having future contract versions as well that their implementation details can be tucked away in a package. I started doing this but can keep everything flat if we don't want to do this |
akuzni2
reviewed
Mar 11, 2025
deployment/data-streams/changeset/call_configurator_set_staging_config.go
Show resolved
Hide resolved
akuzni2
reviewed
Mar 11, 2025
deployment/data-streams/changeset/call_configurator_set_staging_config.go
Show resolved
Hide resolved
akuzni2
reviewed
Mar 11, 2025
deployment/data-streams/changeset/call_configurator_set_production_config.go
Outdated
Show resolved
Hide resolved
akuzni2
reviewed
Mar 11, 2025
deployment/data-streams/changeset/call_configurator_set_staging_config.go
Outdated
Show resolved
Hide resolved
akuzni2
reviewed
Mar 11, 2025
deployment/data-streams/changeset/call_configurator_promote_staging_config.go
Outdated
Show resolved
Hide resolved
akuzni2
reviewed
Mar 11, 2025
| commonChangesets.Configure( | ||
| DeployConfiguratorChangeset, | ||
| DeployConfiguratorConfig{ | ||
| ChainsToDeploy: []uint64{chainSelector}, |
There was a problem hiding this comment.
set MCMS config? Or come back and do this later?
ChrisAmora
force-pushed
the
feat/configurator
branch
from
1103d37 to
50a1fd3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Configurator support for data streams deployment module
References