Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] single node changes #16714

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

Conversation

jinhoonbang
Copy link
Contributor

Draft PR for creating image

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Mar 10, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (.) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Core Tests (go_core_ccip_deployment_tests) , lint , SonarQube Scan

1. File is not properly formatted (goimports): lint

Source of Error:
Golang Lint (.)	2025-03-10T23:48:36.6120326Z ##[error]core/services/job/kv_orm.go:9:1: File is not properly formatted (goimports)
Golang Lint (.)	2025-03-10T23:48:36.6121396Z 	pkgerrors "github.com/pkg/errors"
Golang Lint (.)	2025-03-10T23:48:36.6121914Z ^

Why: The error indicates that the file core/services/job/kv_orm.go is not formatted according to goimports standards. This typically means that the import statements are not organized correctly or there are formatting issues in the code.

Suggested fix: Run goimports on the file core/services/job/kv_orm.go to automatically format the imports and fix any formatting issues. This can be done by running goimports -w core/services/job/kv_orm.go in the terminal.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@ajgrande924 ajgrande924 added the build-publish Build and Publish image to SDLC label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-publish Build and Publish image to SDLC do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants