[CCIP-5323] Compile llo-feeds using forge instead of solc. #16718
Conversation
|
| echo "Compiling" "$contract" | ||
|
|
||
| local command | ||
| command="forge build $CONTRACTS_DIR/src/v0.8/$PROJECT/"$1"/"$2.sol" \ |
There was a problem hiding this comment.
i would imagine we still need the optimisation_runs & a fixed solc version in order to have a deterministic binary. We could perhaps move these to a configuration within the directory. We could potentially move away from deterministic binaries but it requires some thought.. some initial concerns would be:
- How can we determine the compiler settings for each chain, do we migrate this responsibility to tooling?
- Different developers using different compiler versions or settings might produce different bytecode, leading to confusion when comparing results.
There was a problem hiding this comment.
Hi, all the compile settings are controlled by the forge profiles https://github.com/smartcontractkit/chainlink/blob/develop/contracts/foundry.toml . Whenever you need a new setting you can either override the default profile, or you can create your own custom one and set it via the FOUNDRY_PROFILE environment variable.
No description provided.