Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout + default setting to Arbitrum RPC requests #3675

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akuzni2
Copy link
Collaborator

@akuzni2 akuzni2 commented Feb 14, 2025

Description

Expose RPC timeout setting as environment variable

add timing logs

Changes

Steps to Test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: d7a4ed1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mxiao-cll
Copy link
Contributor

Why do we need this?

@akuzni2
Copy link
Collaborator Author

akuzni2 commented Feb 14, 2025

Why do we need this?

@mxiao-cll the default timeout is 2 min in the current ethersjs version (source)

It probably might not ever hit this if the background execute timeout is shorter - but if we don't set something reasonable isn't it possible for the background execute to freeze up?

@mxiao-cll mxiao-cll requested a review from a team February 14, 2025 02:09
@mxiao-cll
Copy link
Contributor

Why do we need this?

@mxiao-cll the default timeout is 2 min in the current ethersjs version (source)

It probably might not ever hit this if the background execute timeout is shorter - but if we don't set something reasonable isn't it possible for the background execute to freeze up?

Q1: What kind of heavy request are we doing here that may exceed the default timeout
Q2: What do you mean background execute to freeze up ? If background execute timeout the request will be cancelled AFAIK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants