Skip to content

Conversation

@mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented Nov 14, 2025

Closes #OPDATA-4973

Description

Refactor & adds address-adhoc endpoint to multi-address-list EA for diagnostic purposes

Changes

  • Refactored existing address transport into common BaseAddressListTransport
  • Wrote new endpoint address-adhoc that bypasses scheduler logic (see ticket for details)

Steps to Test

  1. yarn test multi-address-list
  2. with payload in ticket comments

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@mmcallister-cll mmcallister-cll requested review from a team November 14, 2025 22:11
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: 62bef07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chainlink/multi-address-list-adapter Minor
@chainlink/proof-of-reserves-adapter Patch
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 mmcallister-cll, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!


const logger = makeLogger('BaseAddressListTransport')

export class AddressDebugTransport extends BaseAddressListTransport {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should make this a subscription transport if it is just for debug

Copy link
Contributor Author

@mmcallister-cll mmcallister-cll Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So foreground? If yes then i think I'll probably redo this PR a different way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok gonna move this back to draft then since it was just something i was trying to get in off-sprint for on call

@mmcallister-cll mmcallister-cll marked this pull request as draft November 14, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants