-
Notifications
You must be signed in to change notification settings - Fork 327
Accountable EA #4290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Accountable EA #4290
Conversation
🦋 Changeset detectedLatest commit: f81d5b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new "Accountable" external adapter for fetching Proof of Reserve (PoR) data from multiple clients (Axis and Unitas). The adapter retrieves total reserve information and includes validation for client-specific API keys.
Key Changes:
- New adapter implementation for Accountable EA with support for multiple clients
- Reserve endpoint with dynamic API key validation based on client name
- Comprehensive test coverage including integration tests and fixtures
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/tsconfig.json | Registers the new accountable adapter in the TypeScript project configuration |
| packages/tsconfig.test.json | Adds accountable test configuration to the test compilation setup |
| packages/sources/accountable/package.json | Package configuration for the new adapter |
| packages/sources/accountable/src/index.ts | Main adapter setup with PoR configuration and rate limiting |
| packages/sources/accountable/src/config/index.ts | Configuration for API endpoint requirement |
| packages/sources/accountable/src/endpoint/index.ts | Exports reserve endpoint |
| packages/sources/accountable/src/endpoint/reserve.ts | Reserve endpoint definition with input parameters and validation |
| packages/sources/accountable/src/transport/reserve.ts | HTTP transport implementation for reserve data fetching |
| packages/sources/accountable/test-payload.json | Test payload configuration for the adapter |
| packages/sources/accountable/test/integration/reserve.test.ts | Integration tests for reserve endpoint |
| packages/sources/accountable/test/integration/fixtures.ts | Mock response fixtures for testing |
| packages/sources/accountable/README.md | Documentation for the adapter |
| packages/sources/accountable/CHANGELOG.md | Changelog file for version tracking |
| packages/sources/accountable/tsconfig.json | TypeScript configuration for the adapter |
| packages/sources/accountable/tsconfig.test.json | TypeScript test configuration for the adapter |
Files not reviewed (1)
- .pnp.cjs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/sources/accountable/test/integration/__snapshots__/reserve.test.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- .pnp.cjs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
see if |
@mmcallister-cll we can use generic-api EA as long as we maintain the following env for each client. AXIS_API_URL=https://dvn.accountable.capital/v1/reserves?client=axis Request Response |
Closes #OPDATA-4906
https://smartcontract-it.atlassian.net/browse/OPDATA-4906
Description
Accountable EA
Changes
Steps to Test
yarn test packages/source/accountable
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file or update the soak testing blacklist.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.