Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVSVCS-1213: replace Ganache with Anvil and upgrade webpack and remove esmify #81

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

FelixFan1992
Copy link

No description provided.

@FelixFan1992 FelixFan1992 marked this pull request as ready for review February 4, 2025 16:30
@FelixFan1992 FelixFan1992 changed the title Only webpack and anvil replace Ganache with Anvil and upgrade webpack Feb 4, 2025
@FelixFan1992 FelixFan1992 changed the title replace Ganache with Anvil and upgrade webpack DEVSVCS-1213: replace Ganache with Anvil and upgrade webpack Feb 5, 2025
@@ -28,17 +27,10 @@ export const setupLocalTestnetFixture = async (
}> => {
const localFunctionsTestnet = await startLocalFunctionsTestnet(
path.join(__dirname, 'testSimulationConfig.ts'),
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are using anvil/viem consider whether we need to use fetchLogs [1] for showing the user the console logs?

[1] https://github.com/wevm/anvil.js/tree/main?tab=readme-ov-file#fetchlogs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried this but it is not clear how to work with this.
i tried another approach
anvil.on('message', log -> ....) and it prints some logs.
at the moment i don't have a good way to ensure it's a good user experience bc i only ran unit and integration tests.
will explore this a little more when testing with integration tests repo.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! since its a toolkit for developers it is critical that we have no regression on developer experience.

@FelixFan1992 FelixFan1992 changed the title DEVSVCS-1213: replace Ganache with Anvil and upgrade webpack DEVSVCS-1213: replace Ganache with Anvil and upgrade webpack and remove esmify Feb 12, 2025
@chudilka1 chudilka1 self-requested a review February 20, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants