Skip to content

fix: second-page always flip after first looping #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: second-page always flip after first looping #257

wants to merge 3 commits into from

Conversation

PhyoThihaWin
Copy link

  • Change the flip issue position to last page.
  • But still flip animation obviously and not good at UX,
  • Disable smoothScroll at LastPage->FirstPage.

PhyoThihaWin and others added 3 commits September 22, 2023 10:38
fix: second-page always flip after first looping
3001f22 
- so increase currentPosition continuously and never reset
- AUTO_CYCLE_DIRECTION_BACK_AND_FORTH is different from LEFT and RIGHT
fix: second-page always flip after first looping
cdb2046 
- so increase currentPosition continuously and never reset
- AUTO_CYCLE_DIRECTION_BACK_AND_FORTH is different from LEFT and RIGHT
@PhyoThihaWin
fix: slider-indicator hide on Fragment Initial
041bf1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shubhamdevgupta shubhamdevgupta shubhamdevgupta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhyoThihaWin @shubhamdevgupta